Add paper-listbox to third_party/polymer

Add paper-listbox to third_party/polymer

paper-listbox should be preferred over paper-menu, for implementing
drop-down menus that do not have sub-menus.

BUG=597874
Committed: https://crrev.com/75d440b2169442db1eb18c74bd62318eb881fce9
Cr-Commit-Position: refs/heads/master@{#383752}

[dpapad, 2016-03-28 21:39:03]

Description was changed from

==========
Add paper-listbox to third_party/polymer

BUG=
==========

to

==========
Add paper-listbox to third_party/polymer

paper-listbox should be preferred over paper-menu, for implementing
drop-down menus that do not have sub-menus.
==========

[dpapad, 2016-03-28 22:21:56]

dpapad@chromium.org changed reviewers:
+ michaelpg@chromium.org

[dpapad, 2016-03-28 22:21:57]

FYI, I am using this from my next CL,
https://codereview.chromium.org/1836583003. I think that we should also remove
paper-menu usage elsewhere in Settings, per the information at
https://github.com/PolymerElements/paper-listbox/issues/7
https://github.com/PolymerElements/paper-menu/issues/70
https://github.com/PolymerElements/paper-menu/issues/83

Basically paper-menu was designed to have sub-menus and brings in unnecessary
complexity for the case where no sub-menus exist.

[dpapad, 2016-03-28 22:34:40]

Description was changed from

==========
Add paper-listbox to third_party/polymer

paper-listbox should be preferred over paper-menu, for implementing
drop-down menus that do not have sub-menus.
==========

to

==========
Add paper-listbox to third_party/polymer

paper-listbox should be preferred over paper-menu, for implementing
drop-down menus that do not have sub-menus.

BUG=597874
==========

[michaelpg, 2016-03-29 02:33:41]

adding paper-listmenu lgtm (very happy to replace paper-menu)

On 2016/03/28 22:21:57, dpapad wrote:
> FYI, I am using this from my next CL,
> https://codereview.chromium.org/1836583003. I think that we should also remove
> paper-menu usage elsewhere in Settings, per the information at
> https://github.com/PolymerElements/paper-listbox/issues/7
> https://github.com/PolymerElements/paper-menu/issues/70
> https://github.com/PolymerElements/paper-menu/issues/83
> 
> Basically paper-menu was designed to have sub-menus and brings in unnecessary
> complexity for the case where no sub-menus exist.

and is also deprecated, apparently:
https://docs.google.com/spreadsheets/d/1m0SleaDfRTPzDvlnInip9x4FXT6O98M2W8jwZ...

(the same spreadsheet says 'kill with fire' for paper-material, so we should get
on that...)

[michaelpg, 2016-03-29 02:33:53]

lgtm

https://codereview.chromium.org/1834343002/diff/1/third_party/polymer/v1_0/co...
File third_party/polymer/v1_0/components-chromium/paper-listbox/bower.json
(right):

https://codereview.chromium.org/1834343002/diff/1/third_party/polymer/v1_0/co...
third_party/polymer/v1_0/components-chromium/paper-listbox/bower.json:13:
"paper-sublistbox.html"
weird, this doesn't match the GitHub bower.json. but it's not pulling down this
mysterious non-existent file, so looks okay I guess

[dpapad, 2016-03-29 17:18:50]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2016-03-29 17:19:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834343002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834343002/1

[commit-bot: I haz the power, 2016-03-29 17:24:29]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-29 17:25:24]

Description was changed from

==========
Add paper-listbox to third_party/polymer

paper-listbox should be preferred over paper-menu, for implementing
drop-down menus that do not have sub-menus.

BUG=597874
==========

to

==========
Add paper-listbox to third_party/polymer

paper-listbox should be preferred over paper-menu, for implementing
drop-down menus that do not have sub-menus.

BUG=597874

Committed: https://crrev.com/75d440b2169442db1eb18c74bd62318eb881fce9
Cr-Commit-Position: refs/heads/master@{#383752}
==========

[commit-bot: I haz the power, 2016-03-29 17:25:25]

Patchset 1 (id:??) landed as
https://crrev.com/75d440b2169442db1eb18c74bd62318eb881fce9
Cr-Commit-Position: refs/heads/master@{#383752}

[dpapad, 2016-03-29 17:50:44]

https://codereview.chromium.org/1834343002/diff/1/third_party/polymer/v1_0/co...
File third_party/polymer/v1_0/components-chromium/paper-listbox/bower.json
(right):

https://codereview.chromium.org/1834343002/diff/1/third_party/polymer/v1_0/co...
third_party/polymer/v1_0/components-chromium/paper-listbox/bower.json:13:
"paper-sublistbox.html"
On 2016/03/29 at 02:33:53, michaelpg wrote:
> weird, this doesn't match the GitHub bower.json. but it's not pulling down
this mysterious non-existent file, so looks okay I guess

That is indeed weird. I double checked that when doing
bower install --save polymerelements/paper-listbox

the bower.json that is checked out does not match the Github bower.json.
Guessing that this is an issue on their bower setup.