src/core/SkReadBuffer.cpp - Issue 1834303003: Delete SkFlattenable::Type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkReadBuffer.cpp

Issue 1834303003: Delete SkFlattenable::Type (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkReadBuffer.cpp

diff --git a/src/core/SkReadBuffer.cpp b/src/core/SkReadBuffer.cpp

index 59d5172f8144a66e5e9dafff6b6a9f775b73020a..3f5502d270bc31bdf8cc2f5b947af807cf8033fb 100644

--- a/src/core/SkReadBuffer.cpp

+++ b/src/core/SkReadBuffer.cpp

@@ -333,11 +333,7 @@ SkTypeface* SkReadBuffer::readTypeface() {

}

-SkFlattenable* SkReadBuffer::readFlattenable(SkFlattenable::Type ft) {

- //

- // TODO: confirm that ft matches the factory we decide to use

- //

+SkFlattenable* SkReadBuffer::readFlattenable() {

SkFlattenable::Factory factory = nullptr;

if (fFactoryCount > 0) {