Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1834243003: Revert of Move ScreenWin to ui/display (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
robliao, oshima, sky, piman
CC:
chromium-reviews, yusukes+watch_chromium.org, tfarina, shuchen+watch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move ScreenWin to ui/display (patchset #2 id:160001 of https://codereview.chromium.org/1825723002/ ) Reason for revert: Doesn't build in gn/win component builds: LINK : warning LNK4001: no object files specified; libraries used LINK : error LNK2001: unresolved external symbol _DllMainCRTStartup ./display_test_util.dll : fatal error LNK1120: 1 unresolved externals Original issue's description: > Move ScreenWin to ui/display > > ScreenWin along with other Screen related objects is not really about graphics. > As a result, this goes to a new home called ui/display to hold things related to > the screen and display. > > BUG=597105 > > Committed: https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c > Cr-Commit-Position: refs/heads/master@{#383500} TBR=oshima@chromium.org,piman@chromium.org,sky@chromium.org,robliao@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=597105 Committed: https://crrev.com/a8360d41fdefee4442b861503350b70962d68ffa Cr-Commit-Position: refs/heads/master@{#383552}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1446 lines, -1522 lines) Patch
M content/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M testing/buildbot/chromium.fyi.json View 4 chunks +0 lines, -21 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 4 chunks +0 lines, -24 lines 0 comments Download
M testing/buildbot/chromium.win.json View 4 chunks +0 lines, -19 lines 0 comments Download
M testing/buildbot/chromium_trybot.json View 1 chunk +0 lines, -11 lines 0 comments Download
M ui/display/BUILD.gn View 3 chunks +116 lines, -121 lines 0 comments Download
M ui/display/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
M ui/display/display.gyp View 3 chunks +0 lines, -8 lines 0 comments Download
M ui/display/display_unittests.isolate View 1 chunk +1 line, -1 line 0 comments Download
D ui/display/win/display_info.h View 1 chunk +0 lines, -44 lines 0 comments Download
D ui/display/win/display_info.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D ui/display/win/screen_win.h View 1 chunk +0 lines, -101 lines 0 comments Download
D ui/display/win/screen_win.cc View 1 chunk +0 lines, -242 lines 0 comments Download
D ui/display/win/screen_win_display.h View 1 chunk +0 lines, -36 lines 0 comments Download
D ui/display/win/screen_win_display.cc View 1 chunk +0 lines, -37 lines 0 comments Download
D ui/display/win/screen_win_unittest.cc View 1 chunk +0 lines, -784 lines 0 comments Download
M ui/gfx/BUILD.gn View 4 chunks +7 lines, -0 lines 0 comments Download
M ui/gfx/gfx.gyp View 3 chunks +6 lines, -0 lines 0 comments Download
M ui/gfx/gfx_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A ui/gfx/screen_win.h View 1 chunk +103 lines, -0 lines 0 comments Download
A ui/gfx/screen_win.cc View 1 chunk +243 lines, -0 lines 0 comments Download
A ui/gfx/screen_win_unittest.cc View 1 chunk +782 lines, -0 lines 0 comments Download
A ui/gfx/win/display_info.h View 1 chunk +44 lines, -0 lines 0 comments Download
A ui/gfx/win/display_info.cc View 1 chunk +60 lines, -0 lines 0 comments Download
A ui/gfx/win/screen_win_display.h View 1 chunk +36 lines, -0 lines 0 comments Download
A ui/gfx/win/screen_win_display.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M ui/views/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/views.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_win.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Nico
Created Revert of Move ScreenWin to ui/display
4 years, 8 months ago (2016-03-28 20:27:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1834243003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1834243003/1
4 years, 8 months ago (2016-03-28 20:27:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-28 20:28:40 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 20:29:59 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8360d41fdefee4442b861503350b70962d68ffa
Cr-Commit-Position: refs/heads/master@{#383552}

Powered by Google App Engine
This is Rietveld 408576698