use std::vector in more places in JavaScript bindings code.

use std::vector in more places in JavaScript bindings code.
use unique_ptrs for app:m_Timers.

BUG=

Committed: https://pdfium.googlesource.com/pdfium/+/41a53ad771411db3cdd98822f9d240456767fba8

[Tom Sepez, 2016-03-28 16:37:56]

Description was changed from

==========
unique_ptrs for app:m_Timers.

BUG=
==========

to

==========
use std::vector in more places in JavaScript bindings code.
use unique_ptrs for app:m_Timers.

BUG=
==========

[Tom Sepez, 2016-03-28 16:37:56]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-03-28 16:38:06]

Dan, for review.

[dsinclair, 2016-03-28 18:57:33]

lgtm w/ nits

https://codereview.chromium.org/1834203002/diff/20001/fpdfsdk/javascript/JS_G...
File fpdfsdk/javascript/JS_GlobalData.cpp (right):

https://codereview.chromium.org/1834203002/diff/20001/fpdfsdk/javascript/JS_G...
fpdfsdk/javascript/JS_GlobalData.cpp:214:
m_arrayGlobalData.push_back(std::move(pNewData));
nit: This block is very similar to the others, just with the sData, bData,
objData, etc different. Can we make a constructor for the common bits?

https://codereview.chromium.org/1834203002/diff/20001/fpdfsdk/javascript/JS_R...
File fpdfsdk/javascript/JS_Runtime.cpp (right):

https://codereview.chromium.org/1834203002/diff/20001/fpdfsdk/javascript/JS_R...
fpdfsdk/javascript/JS_Runtime.cpp:126: m_pDocument = NULL;
This isn't needed either as we're destructing, yea?

https://codereview.chromium.org/1834203002/diff/20001/fpdfsdk/javascript/JS_R...
File fpdfsdk/javascript/JS_Runtime.h (right):

https://codereview.chromium.org/1834203002/diff/20001/fpdfsdk/javascript/JS_R...
fpdfsdk/javascript/JS_Runtime.h:13: #include <vector>
nit: #include <memory>

[Tom Sepez, 2016-03-28 23:47:18]

https://codereview.chromium.org/1834203002/diff/20001/fpdfsdk/javascript/JS_G...
File fpdfsdk/javascript/JS_GlobalData.cpp (right):

https://codereview.chromium.org/1834203002/diff/20001/fpdfsdk/javascript/JS_G...
fpdfsdk/javascript/JS_GlobalData.cpp:214:
m_arrayGlobalData.push_back(std::move(pNewData));
On 2016/03/28 18:57:33, dsinclair wrote:
> nit: This block is very similar to the others, just with the sData, bData,
> objData, etc different. Can we make a constructor for the common bits?

Needs a separate CL.  I started this, and pretty much everything had to change
as a result if we wanted to do it right.

https://codereview.chromium.org/1834203002/diff/20001/fpdfsdk/javascript/JS_R...
File fpdfsdk/javascript/JS_Runtime.cpp (right):

https://codereview.chromium.org/1834203002/diff/20001/fpdfsdk/javascript/JS_R...
fpdfsdk/javascript/JS_Runtime.cpp:126: m_pDocument = NULL;
On 2016/03/28 18:57:33, dsinclair wrote:
> This isn't needed either as we're destructing, yea?

Done.

https://codereview.chromium.org/1834203002/diff/20001/fpdfsdk/javascript/JS_R...
File fpdfsdk/javascript/JS_Runtime.h (right):

https://codereview.chromium.org/1834203002/diff/20001/fpdfsdk/javascript/JS_R...
fpdfsdk/javascript/JS_Runtime.h:13: #include <vector>
On 2016/03/28 18:57:33, dsinclair wrote:
> nit: #include <memory>

Done.

[Tom Sepez, 2016-03-28 23:48:50]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-03-28 23:48:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/1834203002/#ps60001
(title: "Nits.")

[commit-bot: I haz the power, 2016-03-28 23:49:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834203002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834203002/60001

[commit-bot: I haz the power, 2016-03-28 23:59:34]

Description was changed from

==========
use std::vector in more places in JavaScript bindings code.
use unique_ptrs for app:m_Timers.

BUG=
==========

to

==========
use std::vector in more places in JavaScript bindings code.
use unique_ptrs for app:m_Timers.

BUG=

Committed:
https://pdfium.googlesource.com/pdfium/+/41a53ad771411db3cdd98822f9d240456767...
==========

[commit-bot: I haz the power, 2016-03-28 23:59:35]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/41a53ad771411db3cdd98822f9d240456767...