fpdfsdk/javascript/JS_Runtime.h - Issue 1834203002: use std::vector in more places in JavaScript bindings code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/javascript/JS_Runtime.h

Issue 1834203002: use std::vector in more places in JavaScript bindings code. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@util_printx

Patch Set: Nits. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/javascript/JS_Runtime.h

diff --git a/fpdfsdk/javascript/JS_Runtime.h b/fpdfsdk/javascript/JS_Runtime.h

index fa13273e5b5582edbc1dc6e5c15b40a43b030bb3..68dfb5b97331f74cc690442522ea497802ec82e8 100644

--- a/fpdfsdk/javascript/JS_Runtime.h

+++ b/fpdfsdk/javascript/JS_Runtime.h

@@ -8,6 +8,7 @@

#define FPDFSDK_JAVASCRIPT_JS_RUNTIME_H_

#include <map>

+#include <memory>

#include <set>

#include <utility>

#include <vector>

@@ -75,8 +76,8 @@ class CJS_Runtime : public IJS_Runtime {

private:

void DefineJSObjects();

- CFX_ArrayTemplate<CJS_Context*> m_ContextArray;

- CPDFDoc_Environment* m_pApp;

+ std::vector<std::unique_ptr<CJS_Context>> m_ContextArray;

+ CPDFDoc_Environment* const m_pApp;

CPDFSDK_Document* m_pDocument;

FX_BOOL m_bBlocking;

std::set<FieldEvent> m_FieldEventSet;

« no previous file with comments | « fpdfsdk/javascript/JS_GlobalData.cpp ('k') | fpdfsdk/javascript/JS_Runtime.cpp » ('j') | no next file with comments »