Make the Firefox trace RegExp not go exponential on V8.

pkg/stack_trace/lib/src/trace.dart

Index: pkg/stack_trace/lib/src/trace.dart
diff --git a/pkg/stack_trace/lib/src/trace.dart b/pkg/stack_trace/lib/src/trace.dart
index 2b9d22a79d86fae9cbb15def31795a14c83d4755..6b7da758dba890c8abd13c9d84701764bf726674 100644
--- a/pkg/stack_trace/lib/src/trace.dart
+++ b/pkg/stack_trace/lib/src/trace.dart
@@ -19,7 +19,7 @@ final _terseRegExp = new RegExp(r"(-patch)?(/.*)?$");
 /// Firefox's trace frames start with the name of the function in which the
 /// error occurred, possibly including its parameters inside `()`. For example,
 /// `.VW.call$0("arg")@http://pub.dartlang.org/stuff.dart.js:560`.
-final _firefoxTrace = new RegExp(r"^([.0-9A-Za-z_$/<]*|\(.*\))*@");
+final _firefoxTrace = new RegExp(r"^([.0-9A-Za-z_$/<]|\(.*\))*@");

[Bob Nystrom, 2013/07/08 22:02:27]

I think this would handle this poorly:

.VW.call$0(")")@http://pub.dartlang.org/stuff.dart.js:560

Add a TODO for that?

[nweiz, 2013/07/08 22:24:49]

The ".*" in "\(.*\)" is greedy; it'll match until the last ")". There's a test
case for that.

 
 /// A RegExp to match this package's stack traces.
 final _friendlyTrace = new RegExp(r"^[^\s]+( \d+:\d+)?\s+[^\s]+($|\n)");