Make the Firefox trace RegExp not go exponential on V8.

pkg/stack_trace/lib/src/trace.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library trace;
 
 import 'dart:collection';
 import 'dart:math' as math;
 
 import 'frame.dart';
 import 'lazy_trace.dart';
 import 'utils.dart';
 import 'vm_trace.dart';
 
 final _terseRegExp = new RegExp(r"(-patch)?(/.*)?$");
 
 /// A RegExp to match Firefox's stack traces.
 ///
 /// Firefox's trace frames start with the name of the function in which the
 /// error occurred, possibly including its parameters inside `()`. For example,
 /// `.VW.call$0("arg")@http://pub.dartlang.org/stuff.dart.js:560`.
-final _firefoxTrace = new RegExp(r"^([.0-9A-Za-z_$/<]*|\(.*\))*@");
+final _firefoxTrace = new RegExp(r"^([.0-9A-Za-z_$/<]|\(.*\))*@");

[Bob Nystrom, 2013/07/08 22:02:27]

I think this would handle this poorly:

.VW.call$0(")")@http://pub.dartlang.org/stuff.dart.js:560

Add a TODO for that?

[nweiz, 2013/07/08 22:24:49]

The ".*" in "\(.*\)" is greedy; it'll match until the last ")". There's a test
case for that.

 
 /// A RegExp to match this package's stack traces.
 final _friendlyTrace = new RegExp(r"^[^\s]+( \d+:\d+)?\s+[^\s]+($|\n)");
 
 /// A stack trace, comprised of a list of stack frames.
 class Trace implements StackTrace {
   /// The stack frames that comprise this stack trace.
   final List<Frame> frames;
 
   /// Returns a human-readable representation of [stackTrace]. If [terse] is
@@ skipping 117 matching lines @@
     // Figure out the longest path so we know how much to pad.
     var longest = frames.map((frame) => frame.location.length)
         .fold(0, math.max);
 
     // Print out the stack trace nicely formatted.
     return frames.map((frame) {
       return '${padRight(frame.location, longest)}  ${frame.member}\n';
     }).join();
   }
 }