Popup loosing focus through keyboard events should update HTMLSelectElement display

third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Index: third_party/WebKit/Source/web/WebPagePopupImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
index 74dce75d81f37924a8a8d4aa38c8674d1dddcc91..0e931dc8c244b954a5358ec7cf2a1df2b3cc5e0d 100644
--- a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
@@ -489,13 +489,7 @@ void WebPagePopupImpl::setFocus(bool enable)
 
 void WebPagePopupImpl::close()
 {
-    m_closing = true;
-    // In case closePopup() was not called.
-    if (m_page) {
-        destroyPage();
-        m_popupClient->didClosePopup();
-        m_webView->cleanupPagePopup();
-    }
+    cancel();

[tkent, 2016/03/25 07:30:44]

Is it safe to call cancel() unconditionally?
In the PopupMenuImpl::setValueAndClosePopup path, we call
WebPagePopupImpl::closePopup, it calls then Chromium calls
WebPagePopupImpl::close().
With this CL, we call WebPagePopupImpl::closePopup again, and some steps are
executed again.

if (m_page)
    cancel();

is more sane?

[keishi, 2016/03/25 07:57:46]

Done.

     m_widgetClient = 0;
     deref();
 }