Popup loosing focus through keyboard events should update HTMLSelectElement display

third_party/WebKit/Source/web/WebPagePopupImpl.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 471 matching lines @@
 {
     if (!m_page)
         return;
     m_page->focusController().setFocused(enable);
     if (enable)
         m_page->focusController().setActive(true);
 }
 
 void WebPagePopupImpl::close()
 {
-    m_closing = true;
-    // In case closePopup() was not called.
-    if (m_page) {
-        destroyPage();
-        m_popupClient->didClosePopup();
-        m_webView->cleanupPagePopup();
-    }
+    cancel();

[tkent, 2016/03/25 07:30:44]

Is it safe to call cancel() unconditionally?
In the PopupMenuImpl::setValueAndClosePopup path, we call
WebPagePopupImpl::closePopup, it calls then Chromium calls
WebPagePopupImpl::close().
With this CL, we call WebPagePopupImpl::closePopup again, and some steps are
executed again.

if (m_page)
    cancel();

is more sane?

[keishi, 2016/03/25 07:57:46]

Done.

     m_widgetClient = 0;
     deref();
 }
 
 void WebPagePopupImpl::closePopup()
 {
     // This function can be called in EventDispatchForbiddenScope for the main
     // document, and the following operations dispatch some events.  It's safe
     // because web authors can't listen the events.
     EventDispatchForbiddenScope::AllowUserAgentEvents allowEvents;
@@ skipping 52 matching lines @@
     // A WebPagePopupImpl instance usually has two references.
     //  - One owned by the instance itself. It represents the visible widget.
     //  - One owned by a WebViewImpl. It's released when the WebViewImpl ask the
     //    WebPagePopupImpl to close.
     // We need them because the closing operation is asynchronous and the widget
     // can be closed while the WebViewImpl is unaware of it.
     return adoptRef(new WebPagePopupImpl(client)).leakRef();
 }
 
 } // namespace blink