Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 183383006: Fix HCheckValue::Canonicalize wrt uninitialized HConstant unique. (Closed)

Created:
6 years, 9 months ago by Yang
Modified:
6 years, 9 months ago
Reviewers:
titzer
CC:
v8-dev
Visibility:
Public.

Description

Fix HCheckValue::Canonicalize wrt uninitialized HConstant unique. R=titzer@chromium.org BUG=348280 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=19642

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M src/hydrogen-instructions.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
A + test/mjsunit/regress/regress-348280.js View 1 chunk +10 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yang
6 years, 9 months ago (2014-03-03 12:21:08 UTC) #1
titzer
https://codereview.chromium.org/183383006/diff/1/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/183383006/diff/1/src/hydrogen-instructions.cc#newcode1570 src/hydrogen-instructions.cc:1570: Unique<Object> unique = HConstant::cast(value())->GetUnique(); Can you move this logic ...
6 years, 9 months ago (2014-03-03 12:42:38 UTC) #2
Yang
On 2014/03/03 12:42:38, titzer wrote: > https://codereview.chromium.org/183383006/diff/1/src/hydrogen-instructions.cc > File src/hydrogen-instructions.cc (right): > > https://codereview.chromium.org/183383006/diff/1/src/hydrogen-instructions.cc#newcode1570 > ...
6 years, 9 months ago (2014-03-03 13:09:36 UTC) #3
titzer
lgtm
6 years, 9 months ago (2014-03-03 15:24:12 UTC) #4
Yang
6 years, 9 months ago (2014-03-04 08:08:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r19642 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698