Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1155)

Side by Side Diff: src/hydrogen-instructions.h

Issue 183383006: Fix HCheckValue::Canonicalize wrt uninitialized HConstant unique. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comment Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen-instructions.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3523 matching lines...) Expand 10 before | Expand all | Expand 10 after
3534 if (!has_double_value_ && !has_external_reference_value_) { 3534 if (!has_double_value_ && !has_external_reference_value_) {
3535 ASSERT(!object_.handle().is_null()); 3535 ASSERT(!object_.handle().is_null());
3536 object_ = Unique<Object>(object_.handle()); 3536 object_ = Unique<Object>(object_.handle());
3537 } 3537 }
3538 } 3538 }
3539 3539
3540 Unique<Object> GetUnique() const { 3540 Unique<Object> GetUnique() const {
3541 return object_; 3541 return object_;
3542 } 3542 }
3543 3543
3544 bool EqualsUnique(Unique<Object> other) const {
3545 return object_.IsInitialized() && object_ == other;
3546 }
3547
3544 #ifdef DEBUG 3548 #ifdef DEBUG
3545 virtual void Verify() V8_OVERRIDE { } 3549 virtual void Verify() V8_OVERRIDE { }
3546 #endif 3550 #endif
3547 3551
3548 DECLARE_CONCRETE_INSTRUCTION(Constant) 3552 DECLARE_CONCRETE_INSTRUCTION(Constant)
3549 3553
3550 protected: 3554 protected:
3551 virtual Range* InferRange(Zone* zone) V8_OVERRIDE; 3555 virtual Range* InferRange(Zone* zone) V8_OVERRIDE;
3552 3556
3553 virtual bool DataEquals(HValue* other) V8_OVERRIDE { 3557 virtual bool DataEquals(HValue* other) V8_OVERRIDE {
(...skipping 3928 matching lines...) Expand 10 before | Expand all | Expand 10 after
7482 virtual bool IsDeletable() const V8_OVERRIDE { return true; } 7486 virtual bool IsDeletable() const V8_OVERRIDE { return true; }
7483 }; 7487 };
7484 7488
7485 7489
7486 #undef DECLARE_INSTRUCTION 7490 #undef DECLARE_INSTRUCTION
7487 #undef DECLARE_CONCRETE_INSTRUCTION 7491 #undef DECLARE_CONCRETE_INSTRUCTION
7488 7492
7489 } } // namespace v8::internal 7493 } } // namespace v8::internal
7490 7494
7491 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 7495 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen-instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698