[Extensions] Convert APIs to use movable types [8]

chrome/browser/extensions/api/omnibox/omnibox_unittest.cc

Index: chrome/browser/extensions/api/omnibox/omnibox_unittest.cc
diff --git a/chrome/browser/extensions/api/omnibox/omnibox_unittest.cc b/chrome/browser/extensions/api/omnibox/omnibox_unittest.cc
index 20a05b56d701affad6f56312cf341286d3012532..75eeafc05a2323a55357117f1cf167d3e95a61f9 100644
--- a/chrome/browser/extensions/api/omnibox/omnibox_unittest.cc
+++ b/chrome/browser/extensions/api/omnibox/omnibox_unittest.cc
@@ -79,9 +79,8 @@ TEST(ExtensionOmniboxTest, DescriptionStylesSimple) {
   scoped_ptr<SendSuggestions::Params> params(
       SendSuggestions::Params::Create(*list));
   EXPECT_TRUE(params);
-  EXPECT_TRUE(params->suggest_results[0].get());

[lazyboy, 2016/03/25 17:57:07]

Here and in other places: should keep an equivalent of this, e.g.:
EXPECT_GT(params->suggest_results.size(), 0u);

[Devlin, 2016/03/29 20:20:35]

Done, though note that's not an equivalent check - previously, if the vector was
empty, it'd crash just as it would in this patch set. ;)

   CompareClassification(styles_expected, StyleTypesToACMatchClassifications(
-      *params->suggest_results[0]));
+                                             params->suggest_results[0]));
 
   // Same input, but swap the order. Ensure it still works.
   scoped_ptr<base::ListValue> swap_list =
@@ -111,9 +110,9 @@ TEST(ExtensionOmniboxTest, DescriptionStylesSimple) {
   scoped_ptr<SendSuggestions::Params> swapped_params(
       SendSuggestions::Params::Create(*swap_list));
   EXPECT_TRUE(swapped_params);
-  EXPECT_TRUE(swapped_params->suggest_results[0].get());
-  CompareClassification(styles_expected, StyleTypesToACMatchClassifications(
-      *swapped_params->suggest_results[0]));
+  CompareClassification(
+      styles_expected,
+      StyleTypesToACMatchClassifications(swapped_params->suggest_results[0]));
 }
 
 //   0123456789
@@ -174,9 +173,8 @@ TEST(ExtensionOmniboxTest, DescriptionStylesCombine) {
   scoped_ptr<SendSuggestions::Params> params(
       SendSuggestions::Params::Create(*list));
   EXPECT_TRUE(params);
-  EXPECT_TRUE(params->suggest_results[0].get());
   CompareClassification(styles_expected, StyleTypesToACMatchClassifications(
-      *params->suggest_results[0]));
+                                             params->suggest_results[0]));
 
   // Try moving the "dim/match" style pair at offset 9. Output should be the
   // same.
@@ -222,9 +220,8 @@ TEST(ExtensionOmniboxTest, DescriptionStylesCombine) {
   scoped_ptr<SendSuggestions::Params> moved_params(
       SendSuggestions::Params::Create(*moved_list));
   EXPECT_TRUE(moved_params);
-  EXPECT_TRUE(moved_params->suggest_results[0].get());
   CompareClassification(styles_expected, StyleTypesToACMatchClassifications(
-      *moved_params->suggest_results[0]));
+                                             moved_params->suggest_results[0]));
 }
 
 //   0123456789
@@ -281,9 +278,8 @@ TEST(ExtensionOmniboxTest, DescriptionStylesCombine2) {
   scoped_ptr<SendSuggestions::Params> params(
       SendSuggestions::Params::Create(*list));
   EXPECT_TRUE(params);
-  EXPECT_TRUE(params->suggest_results[0].get());
   CompareClassification(styles_expected, StyleTypesToACMatchClassifications(
-      *params->suggest_results[0]));
+                                             params->suggest_results[0]));
 }
 
 //   0123456789