[Extensions] Convert APIs to use movable types [8]

chrome/browser/extensions/api/omnibox/omnibox_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <utility>
 
 #include "base/values.h"
 #include "chrome/browser/extensions/api/omnibox/omnibox_api.h"
@@ skipping 61 matching lines @@
   ACMatchClassifications styles_expected;
   styles_expected.push_back(ACMatchClassification(0, kNone));
   styles_expected.push_back(ACMatchClassification(1, kMatch));
   styles_expected.push_back(ACMatchClassification(5, kNone));
   styles_expected.push_back(ACMatchClassification(6, kDim));
   styles_expected.push_back(ACMatchClassification(9, kNone));
 
   scoped_ptr<SendSuggestions::Params> params(
       SendSuggestions::Params::Create(*list));
   EXPECT_TRUE(params);
-  EXPECT_TRUE(params->suggest_results[0].get());

[lazyboy, 2016/03/25 17:57:07]

Here and in other places: should keep an equivalent of this, e.g.:
EXPECT_GT(params->suggest_results.size(), 0u);

[Devlin, 2016/03/29 20:20:35]

Done, though note that's not an equivalent check - previously, if the vector was
empty, it'd crash just as it would in this patch set. ;)

   CompareClassification(styles_expected, StyleTypesToACMatchClassifications(
-      *params->suggest_results[0]));
+                                             params->suggest_results[0]));
 
   // Same input, but swap the order. Ensure it still works.
   scoped_ptr<base::ListValue> swap_list =
       ListBuilder()
           .Append(42)
           .Append(ListBuilder()
                       .Append(DictionaryBuilder()
                                   .Set("content", "content")
                                   .Set("description", "description")
                                   .Set("descriptionStyles",
                                        ListBuilder()
                                            .Append(DictionaryBuilder()
                                                        .Set("type", "dim")
                                                        .Set("offset", 6)
                                                        .Set("length", 3)
                                                        .Build())
                                            .Append(DictionaryBuilder()
                                                        .Set("type", "match")
                                                        .Set("offset", 1)
                                                        .Set("length", 4)
                                                        .Build())
                                            .Build())
                                   .Build())
                       .Build())
           .Build();
 
   scoped_ptr<SendSuggestions::Params> swapped_params(
       SendSuggestions::Params::Create(*swap_list));
   EXPECT_TRUE(swapped_params);
-  EXPECT_TRUE(swapped_params->suggest_results[0].get());
-  CompareClassification(styles_expected, StyleTypesToACMatchClassifications(
-      *swapped_params->suggest_results[0]));
+  CompareClassification(
+      styles_expected,
+      StyleTypesToACMatchClassifications(swapped_params->suggest_results[0]));
 }
 
 //   0123456789
 //   uuuuu
 // +          dd
 // +          mm
 // + mmmm
 // +  dd
 // = 3773unnnn66
 TEST(ExtensionOmniboxTest, DescriptionStylesCombine) {
@@ skipping 40 matching lines @@
   styles_expected.push_back(ACMatchClassification(0, kUrl | kMatch));
   styles_expected.push_back(ACMatchClassification(1, kUrl | kMatch | kDim));
   styles_expected.push_back(ACMatchClassification(3, kUrl | kMatch));
   styles_expected.push_back(ACMatchClassification(4, kUrl));
   styles_expected.push_back(ACMatchClassification(5, kNone));
   styles_expected.push_back(ACMatchClassification(9, kMatch | kDim));
 
   scoped_ptr<SendSuggestions::Params> params(
       SendSuggestions::Params::Create(*list));
   EXPECT_TRUE(params);
-  EXPECT_TRUE(params->suggest_results[0].get());
   CompareClassification(styles_expected, StyleTypesToACMatchClassifications(
-      *params->suggest_results[0]));
+                                             params->suggest_results[0]));
 
   // Try moving the "dim/match" style pair at offset 9. Output should be the
   // same.
   scoped_ptr<base::ListValue> moved_list =
       ListBuilder()
           .Append(42)
           .Append(ListBuilder()
                       .Append(DictionaryBuilder()
                                   .Set("content", "content")
                                   .Set("description", "description")
@@ skipping 25 matching lines @@
                                                        .Set("length", 2)
                                                        .Build())
                                            .Build())
                                   .Build())
                       .Build())
           .Build();
 
   scoped_ptr<SendSuggestions::Params> moved_params(
       SendSuggestions::Params::Create(*moved_list));
   EXPECT_TRUE(moved_params);
-  EXPECT_TRUE(moved_params->suggest_results[0].get());
   CompareClassification(styles_expected, StyleTypesToACMatchClassifications(
-      *moved_params->suggest_results[0]));
+                                             moved_params->suggest_results[0]));
 }
 
 //   0123456789
 //   uuuuu
 // + mmmmm
 // + mmm
 // +   ddd
 // + ddd
 // = 77777nnnnn
 TEST(ExtensionOmniboxTest, DescriptionStylesCombine2) {
@@ skipping 36 matching lines @@
                       .Build())
           .Build();
 
   ACMatchClassifications styles_expected;
   styles_expected.push_back(ACMatchClassification(0, kUrl | kMatch | kDim));
   styles_expected.push_back(ACMatchClassification(5, kNone));
 
   scoped_ptr<SendSuggestions::Params> params(
       SendSuggestions::Params::Create(*list));
   EXPECT_TRUE(params);
-  EXPECT_TRUE(params->suggest_results[0].get());
   CompareClassification(styles_expected, StyleTypesToACMatchClassifications(
-      *params->suggest_results[0]));
+                                             params->suggest_results[0]));
 }
 
 //   0123456789
 //   uuuuu
 // + mmmmm
 // + mmm
 // +   ddd
 // + ddd
 // = 77777nnnnn
 TEST(ExtensionOmniboxTest, DefaultSuggestResult) {
@@ skipping 32 matching lines @@
                                .Build())
                       .Build())
           .Build();
 
   scoped_ptr<SetDefaultSuggestion::Params> params(
       SetDefaultSuggestion::Params::Create(*list));
   EXPECT_TRUE(params);
 }
 
 }  // namespace extensions