chrome/android/java/res/layout/new_tab_page_v2.xml - Issue 1833763002: Add new NTP layout with snippet cards and hide it behind a flag

Unified Diff: chrome/android/java/res/layout/new_tab_page_v2.xml

Issue 1833763002: Add new NTP layout with snippet cards and hide it behind a flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix IntDefs, remove separate scrollview/recyclerview layout file Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/res/layout/new_tab_page.xml ('K') | « chrome/android/java/res/layout/new_tab_page_snippets_card.xml ('k') | chrome/android/java/res/values-sw600dp/dimens.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/new_tab_page_v2.xml

diff --git a/chrome/android/java/res/layout/new_tab_page_v2.xml b/chrome/android/java/res/layout/new_tab_page_v2.xml

new file mode 100644

index 0000000000000000000000000000000000000000..ff1e59ad40ea9eee7f005e97ebf4d67e1cef2e24

--- /dev/null

+++ b/chrome/android/java/res/layout/new_tab_page_v2.xml

@@ -0,0 +1,25 @@

+<?xml version="1.0" encoding="utf-8"?>

dgn 2016/03/31 00:46:44 We might have to experiment with zine+toolbar. Res

newt (away) 2016/03/30 19:03:50 2016

dgn 2016/03/31 00:46:44 File removed.

+ Use of this source code is governed by a BSD-style license that can be

+ found in the LICENSE file. -->

+<org.chromium.chrome.browser.ntp.NewTabPageView

+ xmlns:android="http://schemas.android.com/apk/res/android"

+ xmlns:chrome="http://schemas.android.com/apk/res-auto"

newt (away) 2016/03/30 19:03:50 xmlns:chrome not needed

dgn 2016/03/31 00:46:44 File removed.

+ android:layout_width="match_parent"

+ android:layout_height="match_parent"

+ android:paddingTop="@dimen/tab_strip_height" >

+ <org.chromium.chrome.browser.ntp.v2.NewTabPageRecyclerView

+ xmlns:android="http://schemas.android.com/apk/res/android"

newt (away) 2016/03/30 19:03:49 remove xmlns

dgn 2016/03/31 00:46:44 removed from new_tab_page.xml

+ android:id="@+id/ntp_recycler_view"

+ android:background="@color/ntp_with_cards_bg"

+ android:fillViewport="true"

+ android:layout_width="match_parent"

+ android:layout_height="match_parent"

+ android:focusable="true"

+ android:focusableInTouchMode="true"

+ android:contentDescription="@string/accessibility_new_tab_page" />

newt (away) 2016/03/30 19:03:49 nit: remove extra newline

dgn 2016/03/31 00:46:44 File removed.

+</org.chromium.chrome.browser.ntp.NewTabPageView>