chrome/android/java/res/layout/new_tab_page_v2.xml - Issue 1833763002: Add new NTP layout with snippet cards and hide it behind a flag

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/new_tab_page_v2.xml

Issue 1833763002: Add new NTP layout with snippet cards and hide it behind a flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix IntDefs, remove separate scrollview/recyclerview layout file Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/layout/new_tab_page.xml ('K') | « chrome/android/java/res/layout/new_tab_page_snippets_card.xml ('k') | chrome/android/java/res/values-sw600dp/dimens.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>
	dgn 2016/03/31 00:46:44 We might have to experiment with zine+toolbar. Res We might have to experiment with zine+toolbar. Restore the previous layout that had the toolbar with the RecyclerView
	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
	newt (away) 2016/03/30 19:03:50 2016 2016 dgn 2016/03/31 00:46:44 File removed. Show quoted text On 2016/03/30 19:03:50, newt wrote: > 2016 File removed.
	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <org.chromium.chrome.browser.ntp.NewTabPageView

	7 xmlns:android="http://schemas.android.com/apk/res/android"

	8 xmlns:chrome="http://schemas.android.com/apk/res-auto"
	newt (away) 2016/03/30 19:03:50 xmlns:chrome not needed xmlns:chrome not needed dgn 2016/03/31 00:46:44 File removed. Show quoted text On 2016/03/30 19:03:50, newt wrote: > xmlns:chrome not needed File removed.
	9 android:layout_width="match_parent"

	10 android:layout_height="match_parent"

	11 android:paddingTop="@dimen/tab_strip_height" >

	12

	13 <org.chromium.chrome.browser.ntp.v2.NewTabPageRecyclerView

	14 xmlns:android="http://schemas.android.com/apk/res/android"
	newt (away) 2016/03/30 19:03:49 remove xmlns remove xmlns dgn 2016/03/31 00:46:44 removed from new_tab_page.xml Show quoted text On 2016/03/30 19:03:49, newt wrote: > remove xmlns removed from new_tab_page.xml
	15 android:id="@+id/ntp_recycler_view"

	16 android:background="@color/ntp_with_cards_bg"

	17 android:fillViewport="true"

	18 android:layout_width="match_parent"

	19 android:layout_height="match_parent"

	20 android:focusable="true"

	21 android:focusableInTouchMode="true"

	22 android:contentDescription="@string/accessibility_new_tab_page" />

	23

	24
	newt (away) 2016/03/30 19:03:49 nit: remove extra newline nit: remove extra newline dgn 2016/03/31 00:46:44 File removed. Show quoted text On 2016/03/30 19:03:49, newt wrote: > nit: remove extra newline File removed.
	25 </org.chromium.chrome.browser.ntp.NewTabPageView>

OLD	NEW