Mojom compiler: Port pack tests to the frontend.

Mojom compiler: Port pack tests to the frontend.

We add a new test, TestStructsComputedData, to computed_data_test.go, with a bunch of test cases that correspond to all of the test cases in pack_tests.py and pack_unittests.py. In a later CL we plan to delete those two python tests because we will be deleting the code in pack.py that they test because that logic is now being performed by the frontend instead.

I turns out that pack_tests.py is not actually being run and contains a bug. In this patch I also fix that bug. But I do not bother fixing the problem that it is not being run becuase, as I mentioned, I am about to delete it.

Finally I have eliminated a little duplicate code in computed_data.go.

BUG=#713
R=azani@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/b013d061e7904f5e8a26fe94e64481b01444886d

[rudominer, 2016-03-23 22:54:51]

Description was changed from

==========
Mojom compiler: Port pack tests to the frontend.

BUG=
==========

to

==========
Mojom compiler: Port pack tests to the frontend.

BUG=713
==========

[rudominer, 2016-03-23 22:58:53]

Description was changed from

==========
Mojom compiler: Port pack tests to the frontend.

BUG=713
==========

to

==========
Mojom compiler: Port pack tests to the frontend.

We add a new test, TestStructsComputeData, to computed_data_test.go, with a
bunch of test cases that correspond to all of the test cases in pack_tests.py
and pack_unittests.py. In a later patch we plan to delete those two python tests
because we will be deleting the code in pack.py that they test because that
logic is now being performed by the frontend instead.

BUG=#713
==========

[rudominer, 2016-03-23 23:00:57]

Description was changed from

==========
Mojom compiler: Port pack tests to the frontend.

We add a new test, TestStructsComputeData, to computed_data_test.go, with a
bunch of test cases that correspond to all of the test cases in pack_tests.py
and pack_unittests.py. In a later patch we plan to delete those two python tests
because we will be deleting the code in pack.py that they test because that
logic is now being performed by the frontend instead.

BUG=#713
==========

to

==========
Mojom compiler: Port pack tests to the frontend.

We add a new test, TestStructsComputeData, to computed_data_test.go, with a
bunch of test cases that correspond to all of the test cases in pack_tests.py
and pack_unittests.py. In a later patch we plan to delete those two python tests
because we will be deleting the code in pack.py that they test because that
logic is now being performed by the frontend instead.

In turns out that pack_tests.py is not actually being run and contains a bug. In
this patch I also fix that bug. But I do not bother fixing the problem that it
is not being run becuase, as I mentioned, I am about to delete it.

BUG=#713
==========

[rudominer, 2016-03-23 23:01:40]

Description was changed from

==========
Mojom compiler: Port pack tests to the frontend.

We add a new test, TestStructsComputeData, to computed_data_test.go, with a
bunch of test cases that correspond to all of the test cases in pack_tests.py
and pack_unittests.py. In a later patch we plan to delete those two python tests
because we will be deleting the code in pack.py that they test because that
logic is now being performed by the frontend instead.

In turns out that pack_tests.py is not actually being run and contains a bug. In
this patch I also fix that bug. But I do not bother fixing the problem that it
is not being run becuase, as I mentioned, I am about to delete it.

BUG=#713
==========

to

==========
Mojom compiler: Port pack tests to the frontend.

We add a new test, TestStructsComputeData, to computed_data_test.go, with a
bunch of test cases that correspond to all of the test cases in pack_tests.py
and pack_unittests.py. In a later CL we plan to delete those two python tests
because we will be deleting the code in pack.py that they test because that
logic is now being performed by the frontend instead.

In turns out that pack_tests.py is not actually being run and contains a bug. In
this patch I also fix that bug. But I do not bother fixing the problem that it
is not being run becuase, as I mentioned, I am about to delete it.

BUG=#713
==========

[rudominer, 2016-03-23 23:03:16]

Description was changed from

==========
Mojom compiler: Port pack tests to the frontend.

We add a new test, TestStructsComputeData, to computed_data_test.go, with a
bunch of test cases that correspond to all of the test cases in pack_tests.py
and pack_unittests.py. In a later CL we plan to delete those two python tests
because we will be deleting the code in pack.py that they test because that
logic is now being performed by the frontend instead.

In turns out that pack_tests.py is not actually being run and contains a bug. In
this patch I also fix that bug. But I do not bother fixing the problem that it
is not being run becuase, as I mentioned, I am about to delete it.

BUG=#713
==========

to

==========
Mojom compiler: Port pack tests to the frontend.

We add a new test, TestStructsComputeData, to computed_data_test.go, with a
bunch of test cases that correspond to all of the test cases in pack_tests.py
and pack_unittests.py. In a later CL we plan to delete those two python tests
because we will be deleting the code in pack.py that they test because that
logic is now being performed by the frontend instead.

In turns out that pack_tests.py is not actually being run and contains a bug. In
this patch I also fix that bug. But I do not bother fixing the problem that it
is not being run becuase, as I mentioned, I am about to delete it.

Finally I have eliminated a little duplicate code in computed_data.go.

BUG=#713
==========

[rudominer, 2016-03-23 23:05:06]

Description was changed from

==========
Mojom compiler: Port pack tests to the frontend.

We add a new test, TestStructsComputeData, to computed_data_test.go, with a
bunch of test cases that correspond to all of the test cases in pack_tests.py
and pack_unittests.py. In a later CL we plan to delete those two python tests
because we will be deleting the code in pack.py that they test because that
logic is now being performed by the frontend instead.

In turns out that pack_tests.py is not actually being run and contains a bug. In
this patch I also fix that bug. But I do not bother fixing the problem that it
is not being run becuase, as I mentioned, I am about to delete it.

Finally I have eliminated a little duplicate code in computed_data.go.

BUG=#713
==========

to

==========
Mojom compiler: Port pack tests to the frontend.

We add a new test, TestStructsComputedData, to computed_data_test.go, with a
bunch of test cases that correspond to all of the test cases in pack_tests.py
and pack_unittests.py. In a later CL we plan to delete those two python tests
because we will be deleting the code in pack.py that they test because that
logic is now being performed by the frontend instead.

In turns out that pack_tests.py is not actually being run and contains a bug. In
this patch I also fix that bug. But I do not bother fixing the problem that it
is not being run becuase, as I mentioned, I am about to delete it.

Finally I have eliminated a little duplicate code in computed_data.go.

BUG=#713
==========

[rudominer, 2016-03-23 23:23:24]

rudominer@chromium.org changed reviewers:
+ azani@chromium.org

[rudominer, 2016-03-23 23:23:25]

Hi Alex, ptal

[azani, 2016-03-23 23:32:25]

lgtm

[rudominer, 2016-03-24 06:31:51]

Description was changed from

==========
Mojom compiler: Port pack tests to the frontend.

We add a new test, TestStructsComputedData, to computed_data_test.go, with a
bunch of test cases that correspond to all of the test cases in pack_tests.py
and pack_unittests.py. In a later CL we plan to delete those two python tests
because we will be deleting the code in pack.py that they test because that
logic is now being performed by the frontend instead.

In turns out that pack_tests.py is not actually being run and contains a bug. In
this patch I also fix that bug. But I do not bother fixing the problem that it
is not being run becuase, as I mentioned, I am about to delete it.

Finally I have eliminated a little duplicate code in computed_data.go.

BUG=#713
==========

to

==========
Mojom compiler: Port pack tests to the frontend.

We add a new test, TestStructsComputedData, to computed_data_test.go, with a
bunch of test cases that correspond to all of the test cases in pack_tests.py
and pack_unittests.py. In a later CL we plan to delete those two python tests
because we will be deleting the code in pack.py that they test because that
logic is now being performed by the frontend instead.

I turns out that pack_tests.py is not actually being run and contains a bug. In
this patch I also fix that bug. But I do not bother fixing the problem that it
is not being run becuase, as I mentioned, I am about to delete it.

Finally I have eliminated a little duplicate code in computed_data.go.

BUG=#713
==========

[rudominer, 2016-03-24 06:32:28]

Description was changed from

==========
Mojom compiler: Port pack tests to the frontend.

We add a new test, TestStructsComputedData, to computed_data_test.go, with a
bunch of test cases that correspond to all of the test cases in pack_tests.py
and pack_unittests.py. In a later CL we plan to delete those two python tests
because we will be deleting the code in pack.py that they test because that
logic is now being performed by the frontend instead.

I turns out that pack_tests.py is not actually being run and contains a bug. In
this patch I also fix that bug. But I do not bother fixing the problem that it
is not being run becuase, as I mentioned, I am about to delete it.

Finally I have eliminated a little duplicate code in computed_data.go.

BUG=#713
==========

to

==========
Mojom compiler: Port pack tests to the frontend.

We add a new test, TestStructsComputedData, to computed_data_test.go, with a
bunch of test cases that correspond to all of the test cases in pack_tests.py
and pack_unittests.py. In a later CL we plan to delete those two python tests
because we will be deleting the code in pack.py that they test because that
logic is now being performed by the frontend instead.

I turns out that pack_tests.py is not actually being run and contains a bug. In
this patch I also fix that bug. But I do not bother fixing the problem that it
is not being run becuase, as I mentioned, I am about to delete it.

Finally I have eliminated a little duplicate code in computed_data.go.

BUG=#713
R=azani@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/b013d061e7904f5e8a26fe94e64...
==========

[rudominer, 2016-03-24 06:32:30]

Committed patchset #2 (id:20001) manually as
b013d061e7904f5e8a26fe94e64481b01444886d (presubmit successful).