Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: mojom/mojom_parser/mojom/computed_data.go

Issue 1833593002: Mojom compiler: Port pack tests to the frontend. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Fix spelling of test name. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojom/mojom_parser/mojom/computed_data.go
diff --git a/mojom/mojom_parser/mojom/computed_data.go b/mojom/mojom_parser/mojom/computed_data.go
index fc70091bb5de0c1e17b51c1700ee98df056fa274..615da1a94724c06ea6af5f66f805956b9b17c144 100644
--- a/mojom/mojom_parser/mojom/computed_data.go
+++ b/mojom/mojom_parser/mojom/computed_data.go
@@ -270,22 +270,10 @@ func computePayloadSizeSoFar(field *StructField) uint32 {
func (i *MojomInterface) ComputeFinalData() error {
for _, method := range i.MethodsByOrdinal {
if method.Parameters != nil {
- // Note(rudominer) computeFieldOffsets must be invoked before computeVersionInfo.
- if err := (*method.Parameters).computeFieldOffsets(); err != nil {
- return err
- }
- if err := (*method.Parameters).computeVersionInfo(); err != nil {
- return err
- }
+ return method.Parameters.ComputeFinalData()
}
if method.ResponseParameters != nil {
- // Note(rudominer) computeFieldOffsets must be invoked before computeVersionInfo.
- if err := (*method.ResponseParameters).computeFieldOffsets(); err != nil {
- return err
- }
- if err := (*method.ResponseParameters).computeVersionInfo(); err != nil {
- return err
- }
+ return method.ResponseParameters.ComputeFinalData()
}
}
return nil
« no previous file with comments | « mojo/public/tools/bindings/pylib/mojom/generate/pack_tests.py ('k') | mojom/mojom_parser/parser/computed_data_test.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698