Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1833393002: Migrate google_apis/gcm/* to net::IPAddress. (Closed)

Created:
4 years, 9 months ago by martijnc
Modified:
4 years, 8 months ago
Reviewers:
eroman, Nicolas Zea
CC:
chromium-reviews, eroman, johnme+watch_chromium.org, Peter Beverloo, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate google_apis/gcm/* to net::IPAddress. BUG=496258 Committed: https://crrev.com/bf63918a7958b044bb5f8f3ee1fd887c4813781f Cr-Commit-Position: refs/heads/master@{#383797}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M google_apis/gcm/base/socket_stream_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M google_apis/gcm/engine/connection_handler_impl_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
martijnc
Hi, can you review this patch? Thanks!
4 years, 8 months ago (2016-03-28 21:00:15 UTC) #2
eroman
lgtm
4 years, 8 months ago (2016-03-28 21:01:09 UTC) #4
Nicolas Zea
lgtm
4 years, 8 months ago (2016-03-29 18:58:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1833393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1833393002/1
4 years, 8 months ago (2016-03-29 19:18:06 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 19:52:35 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 19:54:24 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bf63918a7958b044bb5f8f3ee1fd887c4813781f
Cr-Commit-Position: refs/heads/master@{#383797}

Powered by Google App Engine
This is Rietveld 408576698