Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: google_apis/gcm/engine/connection_handler_impl_unittest.cc

Issue 1833393002: Migrate google_apis/gcm/* to net::IPAddress. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « google_apis/gcm/base/socket_stream_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/gcm/engine/connection_handler_impl_unittest.cc
diff --git a/google_apis/gcm/engine/connection_handler_impl_unittest.cc b/google_apis/gcm/engine/connection_handler_impl_unittest.cc
index 36b9ad3de03a59a232b789bc63e898f21d6ffa99..31f39fe8c18ca4b4704620f07fa1d0d468e6cbff 100644
--- a/google_apis/gcm/engine/connection_handler_impl_unittest.cc
+++ b/google_apis/gcm/engine/connection_handler_impl_unittest.cc
@@ -19,6 +19,7 @@
#include "google_apis/gcm/base/mcs_util.h"
#include "google_apis/gcm/base/socket_stream.h"
#include "google_apis/gcm/protocol/mcs.pb.h"
+#include "net/base/ip_address.h"
#include "net/socket/socket_test_util.h"
#include "net/socket/stream_socket.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -189,9 +190,8 @@ class GCMConnectionHandlerImplTest : public testing::Test {
GCMConnectionHandlerImplTest::GCMConnectionHandlerImplTest()
: last_error_(0) {
- net::IPAddressNumber ip_number;
- net::ParseIPLiteralToNumber("127.0.0.1", &ip_number);
- address_list_ = net::AddressList::CreateFromIPAddress(ip_number, kMCSPort);
+ address_list_ = net::AddressList::CreateFromIPAddress(
+ net::IPAddress::IPv4Localhost(), kMCSPort);
}
GCMConnectionHandlerImplTest::~GCMConnectionHandlerImplTest() {
« no previous file with comments | « google_apis/gcm/base/socket_stream_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698