Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Issue 1833103004: cros: Fix Gaia flashing on 2nd show (Closed)

Created:
4 years, 9 months ago by xiyuan
Modified:
4 years, 8 months ago
Reviewers:
achuithb
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Fix Gaia flashing on 2nd show Hide then show a webview tag could cause it to generate additional contenLoad event. Since opacity is used to hide the webview, setting hidden is not necessary. BUG=597979 Committed: https://crrev.com/865b28818b1a7ba60b8221e9fa44704e04c04440 Cr-Commit-Position: refs/heads/master@{#383488}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
xiyuan
My wish is that webview works regardless of the .hidden attribute. But that would be ...
4 years, 9 months ago (2016-03-25 17:18:53 UTC) #2
achuithb
lgtm
4 years, 8 months ago (2016-03-28 09:25:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1833103004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1833103004/1
4 years, 8 months ago (2016-03-28 09:25:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-28 11:06:23 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 11:07:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/865b28818b1a7ba60b8221e9fa44704e04c04440
Cr-Commit-Position: refs/heads/master@{#383488}

Powered by Google App Engine
This is Rietveld 408576698