Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4453)

Unified Diff: chrome/browser/resources/chromeos/login/screen_gaia_signin.js

Issue 1833103004: cros: Fix Gaia flashing on 2nd show (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/login/screen_gaia_signin.js
diff --git a/chrome/browser/resources/chromeos/login/screen_gaia_signin.js b/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
index 05abdf5fd1e912e8064a1794d9ccd77143431a34..6a06b34b72cf07977bde96d9c27cc53d2d32c007 100644
--- a/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
+++ b/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
@@ -333,8 +333,12 @@ login.createScreen('GaiaSigninScreen', 'gaia-signin', function() {
*/
showLoadingUI_: function(show) {
$('gaia-loading').hidden = !show;
- this.getSigninFrame_().hidden = show;
this.classList.toggle('loading', show);
+ // Only set hidden for offline-gaia and not set it on the 'sign-frame'
+ // webview element. Setting it on webview not only hides but also affects
+ // its loading events.
+ if (this.isOffline)
+ this.getSigninFrame_().hidden = show;
$('signin-frame').classList.remove('show');
this.updateControlsState();
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698