Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 18331012: Relax test expectations for test-cpu-profiler/FunctionApplySample (Closed)

Created:
7 years, 5 months ago by yurys
Modified:
7 years, 5 months ago
Reviewers:
Jakob Kummerow, loislo
CC:
v8-dev
Visibility:
Public.

Description

Relax test expectations for test-cpu-profiler/FunctionApplySample The profile may look a bit different on the bots (see below). We expected this only under GC stress testing, the change makes regular expectations the same. [Top down]: 68 0 (root) [-1] #0 1 1 1 (program) [-1] #0 2 67 65 start [-1] #16 3 2 0 (unresolved function) [-1] #0 4 2 2 apply [-1] #0 5 BUG=None TBR=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15470

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M test/cctest/test-cpu-profiler.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
7 years, 5 months ago (2013-07-03 14:23:19 UTC) #1
yurys
Committed patchset #1 manually as r15470 (presubmit successful).
7 years, 5 months ago (2013-07-03 14:23:42 UTC) #2
Jakob Kummerow
7 years, 5 months ago (2013-07-03 14:34:06 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698