Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: test/cctest/test-cpu-profiler.cc

Issue 18331012: Relax test expectations for test-cpu-profiler/FunctionApplySample (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-cpu-profiler.cc
diff --git a/test/cctest/test-cpu-profiler.cc b/test/cctest/test-cpu-profiler.cc
index 97636a35ff0ea313507176717b5951be060e4162..0ae1a9ef7ee875a09bd0fe4feadfc743fd6c7625 100644
--- a/test/cctest/test-cpu-profiler.cc
+++ b/test/cctest/test-cpu-profiler.cc
@@ -1169,13 +1169,7 @@ TEST(FunctionApplySample) {
CheckChildrenNames(root, names);
}
- // In case of GC stress tests all samples may be in GC phase and there
- // won't be |start| node in the profile.
- bool is_gc_stress_testing =
- (i::FLAG_gc_interval != -1) || i::FLAG_stress_compaction;
-
const v8::CpuProfileNode* startNode = FindChild(root, "start");
- CHECK(is_gc_stress_testing || startNode);
if (startNode) {
{
ScopedVector<v8::Handle<v8::String> > names(2);
@@ -1185,7 +1179,6 @@ TEST(FunctionApplySample) {
}
const v8::CpuProfileNode* testNode = FindChild(startNode, "test");
- CHECK(is_gc_stress_testing || testNode);
if (testNode) {
ScopedVector<v8::Handle<v8::String> > names(2);
names[0] = v8::String::New("bar");
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698