Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1833033003: C++ Bindings: Remove 'inline' arg from generated union serialization functions. (Closed)

Created:
4 years, 9 months ago by vardhan
Modified:
4 years, 9 months ago
Reviewers:
azani, viettrungluu
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

C++ Bindings: Remove 'inline' arg from generated union serialization functions. Previous to this CL, you could serialize a union 'inline' or 'out of line'. This is never useful (you always want to serialize 'inline', and the serialization routine will serialize 'out of line' when it tries to serialize a union inside a union) outside of unittests, and is never expected to be used by a user of the serialization API. This CL basically removes this argument from GetSerializedSize_() and SerializeUnion_(), and updates its consumers. R=azani@chromium.org, viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b26cde572364fbb2d0a3fb8368fed8ab05afaa8d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -112 lines) Patch
M mojo/public/cpp/bindings/lib/array_serialization.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/map_serialization.h View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/tests/union_unittest.cc View 21 chunks +74 lines, -72 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl View 3 chunks +3 lines, -6 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/union_serialization_declaration.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl View 4 chunks +34 lines, -26 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
vardhan
ptal
4 years, 9 months ago (2016-03-25 01:16:00 UTC) #1
azani
lgtm
4 years, 9 months ago (2016-03-25 01:55:49 UTC) #2
vardhan
4 years, 9 months ago (2016-03-25 21:34:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b26cde572364fbb2d0a3fb8368fed8ab05afaa8d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698