Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: mojo/public/cpp/bindings/lib/array_serialization.h

Issue 1833033003: C++ Bindings: Remove 'inline' arg from generated union serialization functions. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/public/cpp/bindings/lib/map_serialization.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/bindings/lib/array_serialization.h
diff --git a/mojo/public/cpp/bindings/lib/array_serialization.h b/mojo/public/cpp/bindings/lib/array_serialization.h
index 3ffaf03a3d02c69b2690eb8b597166de1fdce6ba..7119baa921e6304f16f07313ef46cda0c9df5f3d 100644
--- a/mojo/public/cpp/bindings/lib/array_serialization.h
+++ b/mojo/public/cpp/bindings/lib/array_serialization.h
@@ -434,7 +434,7 @@ struct ArraySerializer<U, U_Data, true> {
for (size_t i = 0; i < input.size(); ++i) {
// GetSerializedSize_ will account for both the data in the union and the
// space in the array used to hold the union.
- size += GetSerializedSize_(input[i], false);
+ size += GetSerializedSize_(input[i]);
}
return size;
}
@@ -448,7 +448,7 @@ struct ArraySerializer<U, U_Data, true> {
const ArrayValidateParams* validate_params) {
for (size_t i = 0; i < num_elements; ++i, ++it) {
U_Data* result = output->storage() + i;
- auto retval = SerializeUnion_(it->get(), buf, &result, true);
+ auto retval = SerializeUnion_(it->get(), buf, &result);
if (retval != ValidationError::NONE)
return retval;
if (!validate_params->element_is_nullable && output->at(i).is_null()) {
« no previous file with comments | « no previous file | mojo/public/cpp/bindings/lib/map_serialization.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698