Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 1832883002: Skip toolchain downloads for a few android tools (Closed)

Created:
4 years, 9 months ago by rmistry
Modified:
4 years, 8 months ago
Reviewers:
borenet, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Skip toolchain downloads for a few android tools. This is an attempt to avoid downloading the android toolchain when not required. I went through all binaries listed in https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/recipe_modules/skia/android_flavor.py except for android_ninja. BUG=skia:5119 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1832883002 Committed: https://skia.googlesource.com/skia/+/8ce5912fe3b18aede140ddaeed014427472c1b30

Patch Set 1 : Initial upload #

Patch Set 2 : Cleanup #

Patch Set 3 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M platform_tools/android/bin/adb_pull_if_needed View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M platform_tools/android/bin/adb_push_if_needed View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M platform_tools/android/bin/adb_wait_for_device View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M platform_tools/android/bin/android_kill_skia View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M platform_tools/android/bin/android_run_skia View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M platform_tools/android/bin/android_setup.sh View 1 2 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
rmistry
Derek, WDYT?
4 years, 9 months ago (2016-03-24 16:59:10 UTC) #4
djsollen
I would do this in reverse where we download the toolchain unless an environment variable ...
4 years, 9 months ago (2016-03-24 19:05:36 UTC) #6
rmistry
Updated CL to skip toolchain setup when env variable is set. I went through all ...
4 years, 8 months ago (2016-03-28 14:39:50 UTC) #10
djsollen
lgtm
4 years, 8 months ago (2016-03-28 15:42:59 UTC) #11
borenet
LGTM
4 years, 8 months ago (2016-03-28 16:18:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832883002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832883002/60001
4 years, 8 months ago (2016-03-28 16:25:43 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 16:35:45 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://skia.googlesource.com/skia/+/8ce5912fe3b18aede140ddaeed014427472c1b30

Powered by Google App Engine
This is Rietveld 408576698