platform_tools/android/bin/android_kill_skia - Issue 1832883002: Skip toolchain downloads for a few android tools

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: platform_tools/android/bin/android_kill_skia

Issue 1832883002: Skip toolchain downloads for a few android tools (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: Address comment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 #!/bin/bash	1 #!/bin/bash

2 #	2 #

3 # android_kill_skia: kills any skia processes on the device.	3 # android_kill_skia: kills any skia processes on the device.

4	4

5 SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"	5 SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"

6	6

	7 SKIP_TOOLCHAIN_SETUP="true"

7 source $SCRIPT_DIR/android_setup.sh	8 source $SCRIPT_DIR/android_setup.sh

8 source $SCRIPT_DIR/utils/setup_adb.sh	9 source $SCRIPT_DIR/utils/setup_adb.sh

9	10

10 if [ $(uname) == "Linux" ]; then	11 if [ $(uname) == "Linux" ]; then

11 $ADB $DEVICE_SERIAL shell ps \| grep skia \| awk '{print $2}' \| xargs -r $ADB $DEVICE_SERIAL shell kill	12 $ADB $DEVICE_SERIAL shell ps \| grep skia \| awk '{print $2}' \| xargs -r $ADB $DEVICE_SERIAL shell kill

12 elif [ $(uname) == "Darwin" ]; then	13 elif [ $(uname) == "Darwin" ]; then

13 $ADB $DEVICE_SERIAL shell ps \| grep skia \| awk '{print $2}' \| xargs $ADB $DE VICE_SERIAL shell kill	14 $ADB $DEVICE_SERIAL shell ps \| grep skia \| awk '{print $2}' \| xargs $ADB $DE VICE_SERIAL shell kill

14 else	15 else

15 echo "Could not automatically determine OS!"	16 echo "Could not automatically determine OS!"

16 exit 1;	17 exit 1;

17 fi	18 fi

OLD	NEW