Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issue 1832813002: Add mojom module suffix in .mojom files in content. (Closed)

Created:
4 years, 9 months ago by leonhsl(Using Gerrit)
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez, jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, posciak+watch_chromium.org, johnme+watch_chromium.org, nasko+codewatch_chromium.org, yzshen+watch_chromium.org, nyquist+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, kinuko+watch, ben+mojo_chromium.org, jsbell+serviceworker_chromium.org, wjmaclean, maniscalco+watch-blimp_chromium.org, mlamouri+watch-geolocation_chromium.org, Aaron Boodman, lcwu+watch_chromium.org, tzik, jam, abarth-chromium, eme-reviews_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, darin-cc_chromium.org, halliwell+watch_chromium.org, harkness+watch_chromium.org, android-webview-reviews_chromium.org, blink-worker-reviews_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, toyoshim+midi_chromium.org, nhiroki, feature-media-reviews_chromium.org, Michael van Ouwerkerk, mlamouri+watch-permissions_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, michaeln, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, serviceworker-reviews, mcasas+watch_chromium.org, mvanouwerkerk+watch_chromium.org, kinuko+serviceworker, mkwst+moarreviews-renderer_chromium.org, horo+watch_chromium.org, darin (slow to review), dtrainor+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add mojom module suffix in .mojom files in content. 'module content;' --> 'module content.mojom;' This way generated bindings will consistently live in a mojom sub-namespace and avoid collision with non-mojom types. This CL is for these .mojom files: content/common/leveldb_wrapper.mojom content/common/permission_service.mojom content/common/storage_partition_service.mojom content/common/vr_service.mojom content/common/wake_lock_service.mojom content/public/common/permission_status.mojom content/public/test/test_mojo_service.mojom content/test/data/web_ui_test_mojo_bindings.mojom BUG=588964 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/06e5566014d8f89968a485cb3a0ce53dd8858aed Cr-Commit-Position: refs/heads/master@{#383456}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : Address Tom's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+524 lines, -479 lines) Patch
M android_webview/browser/aw_permission_manager.h View 3 chunks +12 lines, -9 lines 0 comments Download
M android_webview/browser/aw_permission_manager.cc View 8 chunks +14 lines, -14 lines 0 comments Download
M blimp/engine/app/blimp_permission_manager.h View 2 chunks +8 lines, -5 lines 0 comments Download
M blimp/engine/app/blimp_permission_manager.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/notifications/notification_permission_context_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/permissions/permission_manager.h View 3 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/permissions/permission_manager.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/permissions/permission_manager_unittest.cc View 10 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/permissions/permission_uma_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/push_messaging/push_messaging_service_impl.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chromecast/browser/cast_permission_manager.h View 2 chunks +8 lines, -5 lines 0 comments Download
M chromecast/browser/cast_permission_manager.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M content/browser/dom_storage/dom_storage_context_wrapper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/dom_storage/dom_storage_context_wrapper.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M content/browser/leveldb_wrapper_impl.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/leveldb_wrapper_impl.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/media/cdm/browser_cdm_manager.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M content/browser/mojo_shell_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/permissions/permission_service_context.h View 1 1 chunk +8 lines, -4 lines 0 comments Download
M content/browser/permissions/permission_service_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/permissions/permission_service_impl.h View 3 chunks +24 lines, -22 lines 0 comments Download
M content/browser/permissions/permission_service_impl.cc View 1 12 chunks +41 lines, -39 lines 0 comments Download
M content/browser/push_messaging/push_messaging_message_filter.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 3 chunks +6 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_version_unittest.cc View 1 4 chunks +9 lines, -8 lines 0 comments Download
M content/browser/storage_partition_impl.h View 4 chunks +5 lines, -5 lines 0 comments Download
M content/browser/storage_partition_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/vr/android/cardboard/cardboard_vr_device.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/vr/android/cardboard/cardboard_vr_device.cc View 1 2 3 7 chunks +18 lines, -18 lines 0 comments Download
M content/browser/vr/test/fake_vr_device.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/vr/test/fake_vr_device.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/vr/vr_device.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/vr/vr_device_manager.h View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/vr/vr_device_manager.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M content/browser/vr/vr_device_manager_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/wake_lock/wake_lock_browsertest.cc View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/wake_lock/wake_lock_service_context.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/wake_lock/wake_lock_service_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/wake_lock/wake_lock_service_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/wake_lock/wake_lock_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/web_ui_mojo_browsertest.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M content/child/permissions/permission_dispatcher.h View 3 chunks +7 lines, -7 lines 0 comments Download
M content/child/permissions/permission_dispatcher.cc View 1 10 chunks +30 lines, -30 lines 0 comments Download
M content/common/leveldb_wrapper.mojom View 1 chunk +1 line, -1 line 0 comments Download
M content/common/permission_service.mojom View 1 chunk +1 line, -1 line 0 comments Download
M content/common/storage_partition_service.mojom View 1 chunk +1 line, -1 line 0 comments Download
M content/common/vr_service.mojom View 1 chunk +1 line, -1 line 0 comments Download
M content/common/wake_lock_service.mojom View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/permission_manager.h View 4 chunks +5 lines, -5 lines 0 comments Download
M content/public/common/permission_status.mojom View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/test_mojo_app.h View 1 2 3 4 2 chunks +7 lines, -7 lines 0 comments Download
M content/public/test/test_mojo_app.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/public/test/test_mojo_service.mojom View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/dom_storage/local_storage_cached_area.h View 1 2 chunks +12 lines, -7 lines 0 comments Download
M content/renderer/dom_storage/local_storage_cached_area.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M content/renderer/dom_storage/local_storage_cached_areas.h View 1 3 chunks +5 lines, -2 lines 0 comments Download
M content/renderer/dom_storage/local_storage_cached_areas.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M content/renderer/geolocation_dispatcher.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/geolocation_dispatcher.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M content/renderer/media/media_permission_dispatcher.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/media_permission_dispatcher.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M content/renderer/media/midi_dispatcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/midi_dispatcher.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M content/renderer/notification_permission_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/notification_permission_dispatcher.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/vr/vr_dispatcher.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/vr/vr_dispatcher.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M content/renderer/vr/vr_type_converters.h View 1 chunk +20 lines, -16 lines 0 comments Download
M content/renderer/vr/vr_type_converters.cc View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M content/renderer/wake_lock/wake_lock_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/layout_test/layout_test_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/layout_test/layout_test_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/layout_test/layout_test_notification_manager.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_permission_manager.h View 1 3 chunks +11 lines, -10 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_permission_manager.cc View 1 9 chunks +14 lines, -13 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_push_messaging_service.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/shell/browser/shell_permission_manager.h View 2 chunks +8 lines, -7 lines 0 comments Download
M content/shell/browser/shell_permission_manager.cc View 1 5 chunks +12 lines, -12 lines 0 comments Download
M content/shell/common/layout_test/layout_test_messages.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download
M content/test/data/web_ui_test_mojo_bindings.mojom View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 28 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832813002/1
4 years, 9 months ago (2016-03-24 13:46:09 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/40083)
4 years, 9 months ago (2016-03-24 13:56:21 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832813002/20001
4 years, 9 months ago (2016-03-25 03:09:09 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/40793) android_compile_dbg on ...
4 years, 9 months ago (2016-03-25 03:22:59 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832813002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832813002/40001
4 years, 9 months ago (2016-03-25 06:08:21 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/40636) cast_shell_android on ...
4 years, 9 months ago (2016-03-25 06:21:21 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832813002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832813002/60001
4 years, 9 months ago (2016-03-25 06:52:40 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-25 08:18:37 UTC) #17
leonhsl(Using Gerrit)
After this CL landed, all .mojom in //content will have the 'content.mojom' module name. Would ...
4 years, 9 months ago (2016-03-25 08:48:33 UTC) #19
Tom Sepez
lgtm https://codereview.chromium.org/1832813002/diff/60001/content/browser/wake_lock/wake_lock_browsertest.cc File content/browser/wake_lock/wake_lock_browsertest.cc (right): https://codereview.chromium.org/1832813002/diff/60001/content/browser/wake_lock/wake_lock_browsertest.cc#newcode77 content/browser/wake_lock/wake_lock_browsertest.cc:77: // update nit: format https://codereview.chromium.org/1832813002/diff/60001/content/public/test/test_mojo_app.h File content/public/test/test_mojo_app.h (right): ...
4 years, 9 months ago (2016-03-25 15:42:27 UTC) #20
jam
lgtm
4 years, 9 months ago (2016-03-25 22:14:19 UTC) #21
leonhsl(Using Gerrit)
Thanks a lot for kindly review! Addressed nit comments and will land~ https://codereview.chromium.org/1832813002/diff/60001/content/browser/wake_lock/wake_lock_browsertest.cc File content/browser/wake_lock/wake_lock_browsertest.cc ...
4 years, 9 months ago (2016-03-26 14:34:30 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832813002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832813002/80001
4 years, 9 months ago (2016-03-26 15:38:41 UTC) #25
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 9 months ago (2016-03-26 17:19:54 UTC) #26
commit-bot: I haz the power
4 years, 9 months ago (2016-03-26 17:21:14 UTC) #28
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/06e5566014d8f89968a485cb3a0ce53dd8858aed
Cr-Commit-Position: refs/heads/master@{#383456}

Powered by Google App Engine
This is Rietveld 408576698