content/shell/browser/shell_permission_manager.h - Issue 1832813002: Add mojom module suffix in .mojom files in content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell_permission_manager.h

Issue 1832813002: Add mojom module suffix in .mojom files in content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Tom's comment Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/browser/layout_test/layout_test_push_messaging_service.cc ('k') | content/shell/browser/shell_permission_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/shell_permission_manager.h

diff --git a/content/shell/browser/shell_permission_manager.h b/content/shell/browser/shell_permission_manager.h

index 480bd35a5d1bcf664a7b2fb2864198f6d2a26784..79333afe888a84b3df4af9acb1191af24df00489 100644

--- a/content/shell/browser/shell_permission_manager.h

+++ b/content/shell/browser/shell_permission_manager.h

@@ -21,20 +21,21 @@ class ShellPermissionManager : public PermissionManager {

PermissionType permission,

RenderFrameHost* render_frame_host,

const GURL& requesting_origin,

- const base::Callback<void(PermissionStatus)>& callback) override;

+ const base::Callback<void(mojom::PermissionStatus)>& callback) override;

int RequestPermissions(

const std::vector<PermissionType>& permission,

RenderFrameHost* render_frame_host,

const GURL& requesting_origin,

- const base::Callback<void(

- const std::vector<PermissionStatus>&)>& callback) override;

+ const base::Callback<void(const std::vector<mojom::PermissionStatus>&)>&

+ callback) override;

void CancelPermissionRequest(int request_id) override;

void ResetPermission(PermissionType permission,

const GURL& requesting_origin,

const GURL& embedding_origin) override;

- PermissionStatus GetPermissionStatus(PermissionType permission,

- const GURL& requesting_origin,

- const GURL& embedding_origin) override;

+ mojom::PermissionStatus GetPermissionStatus(

+ PermissionType permission,

+ const GURL& requesting_origin,

+ const GURL& embedding_origin) override;

void RegisterPermissionUsage(PermissionType permission,

const GURL& requesting_origin,

const GURL& embedding_origin) override;

@@ -42,7 +43,7 @@ class ShellPermissionManager : public PermissionManager {

PermissionType permission,

const GURL& requesting_origin,

const GURL& embedding_origin,

- const base::Callback<void(PermissionStatus)>& callback) override;

+ const base::Callback<void(mojom::PermissionStatus)>& callback) override;

void UnsubscribePermissionStatusChange(int subscription_id) override;

private: