tools/dom/templates/html/impl/impl_IDBDatabase.darttemplate - Issue 1832713002: Optimize dartium dart:html bindings so real world application performance is acceptable. Improves d…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/templates/html/impl/impl_IDBDatabase.darttemplate

Issue 1832713002: Optimize dartium dart:html bindings so real world application performance is acceptable. Improves d… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: update cached patches Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/dom/templates/html/impl/impl_HTMLElement.darttemplate ('k') | tools/dom/templates/html/impl/impl_MessageEvent.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/dom/templates/html/impl/impl_IDBDatabase.darttemplate

diff --git a/tools/dom/templates/html/impl/impl_IDBDatabase.darttemplate b/tools/dom/templates/html/impl/impl_IDBDatabase.darttemplate

index 8a74ad329f59974ad4963c7934f2ed06ffdff33a..3d396ef698399b472137bde13247fb6db1ebcd43 100644

--- a/tools/dom/templates/html/impl/impl_IDBDatabase.darttemplate

+++ b/tools/dom/templates/html/impl/impl_IDBDatabase.darttemplate

@@ -72,14 +72,14 @@ $else

if (storeName_OR_storeNames == null) {

throw new ArgumentError("stores may not be null in transaction");

} else if (storeName_OR_storeNames is String || storeName_OR_storeNames is DomStringList) {

- names = unwrap_jso(storeName_OR_storeNames);

+ names = storeName_OR_storeNames;

} else if (storeName_OR_storeNames is List<String>) {

names = convertDartToNative_List(storeName_OR_storeNames);

} else {

throw new ArgumentError("Invalid store(s) $store_Name_OR_storeNames");

}

- return wrap_jso(_blink.BlinkIDBDatabase.instance.transaction_Callback_2_(unwrap_jso(this), names, mode));

+ return _blink.BlinkIDBDatabase.instance.transaction_Callback_2_(this, names, mode);

}

Transaction transactionList(List<String> storeNames, String mode) => transaction(storeNames, mode);