tools/dom/templates/html/impl/impl_HTMLElement.darttemplate - Issue 1832713002: Optimize dartium dart:html bindings so real world application performance is acceptable. Improves d…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/templates/html/impl/impl_HTMLElement.darttemplate

Issue 1832713002: Optimize dartium dart:html bindings so real world application performance is acceptable. Improves d… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: update cached patches Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate ('k') | tools/dom/templates/html/impl/impl_IDBDatabase.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/dom/templates/html/impl/impl_HTMLElement.darttemplate

diff --git a/tools/dom/templates/html/impl/impl_HTMLElement.darttemplate b/tools/dom/templates/html/impl/impl_HTMLElement.darttemplate

index 1d126319e53388315f106ecdf964f9255fe309a9..2f16d16aafcee46035e069b8696765e3202ec689 100644

--- a/tools/dom/templates/html/impl/impl_HTMLElement.darttemplate

+++ b/tools/dom/templates/html/impl/impl_HTMLElement.darttemplate

@@ -7,18 +7,4 @@ part of $LIBRARYNAME;

@DocsEditable()

$(ANNOTATIONS)$(NATIVESPEC)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS {

$!MEMBERS

-$if DARTIUM

- // Flags to only try upgrading once. If there's a failure don't try upgrading

- // anymore.

- bool _badUpgradeOccurred = false;

- /// Required for SDK Infrastructure. Internal use only.

- ///

- /// Did this encounter a failure attempting to upgrade to

- /// a custom element.

- @Deprecated("Required for SDK Infrastructure. Internal use only.")

- bool get isBadUpgrade => _badUpgradeOccurred;

- void _badUpgrade() { _badUpgradeOccurred = true; }

-$endif

}