Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: mojo/mojom_bindings_generator_explicit.gypi

Issue 1832703002: Mojo: Simplify typemap usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-bindings-variant-import
Patch Set: add missing mash dependency Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/mojom_bindings_generator.gypi ('k') | mojo/public/cpp/bindings/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/mojom_bindings_generator_explicit.gypi
diff --git a/mojo/mojom_bindings_generator_explicit.gypi b/mojo/mojom_bindings_generator_explicit.gypi
index e3bb2e84552890564ef809db5d0ffbffc35d7188..ea484de7c6fe782885c082cd24b5c182b3531311 100644
--- a/mojo/mojom_bindings_generator_explicit.gypi
+++ b/mojo/mojom_bindings_generator_explicit.gypi
@@ -12,14 +12,15 @@
'for_blink%': 'false',
},
'mojom_variant%': '<(mojom_variant)',
+ 'mojom_typemaps%': [],
'for_blink%': '<(for_blink)',
'mojom_base_output_dir':
'<!(python <(DEPTH)/build/inverse_depth.py <(DEPTH))',
'mojom_generated_outputs': [
'<!@(python <(DEPTH)/mojo/public/tools/bindings/mojom_list_outputs.py --basedir <(mojom_base_output_dir) --variant <(mojom_variant) <@(mojom_files))',
],
+ 'generated_typemap_file': '<(SHARED_INTERMEDIATE_DIR)/<(mojom_base_output_dir)/<(_target_name)_type_mappings',
'mojom_include_path%': '<(DEPTH)',
- 'mojom_extra_generator_args%': [],
'require_interface_bindings%': 1,
'conditions': [
['mojom_variant=="none"', {
@@ -65,6 +66,22 @@
'outputs': [ '<(stamp_filename)' ],
},
{
+ 'variables': {
+ 'output': '<(generated_typemap_file)',
+ },
+ 'action_name': '<(_target_name)_type_mappings',
+ 'action': [
+ 'python', '<(DEPTH)/mojo/public/tools/bindings/generate_type_mappings.py',
+ '--output',
+ '<(output)',
+ '<!@(python <(DEPTH)/mojo/public/tools/bindings/format_typemap_generator_args.py <@(mojom_typemaps))',
+ ],
+ 'inputs':[
+ '<(DEPTH)/mojo/public/tools/bindings/generate_type_mappings.py',
+ ],
+ 'outputs': [ '<(output)' ],
+ },
+ {
'action_name': '<(_target_name)_mojom_bindings_generator',
'variables': {
'java_out_dir': '<(PRODUCT_DIR)/java_mojo/<(_target_name)/src',
@@ -79,6 +96,7 @@
'<@(mojom_bindings_generator_sources)',
'<@(mojom_files)',
'<(stamp_filename)',
+ '<(generated_typemap_file)',
'<(SHARED_INTERMEDIATE_DIR)/mojo/public/tools/bindings/cpp_templates.zip',
'<(SHARED_INTERMEDIATE_DIR)/mojo/public/tools/bindings/java_templates.zip',
'<(SHARED_INTERMEDIATE_DIR)/mojo/public/tools/bindings/js_templates.zip',
@@ -96,7 +114,8 @@
'--java_output_directory=<(java_out_dir)',
'--variant', '<(mojom_variant)',
'-g', '<(mojom_output_languages)',
- '<@(mojom_extra_generator_args)',
+ '--typemap',
+ '<(generated_typemap_file)',
'<@(mojom_generator_wtf_arg)',
'--bytecode_path',
'<(SHARED_INTERMEDIATE_DIR)/mojo/public/tools/bindings',
« no previous file with comments | « mojo/mojom_bindings_generator.gypi ('k') | mojo/public/cpp/bindings/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698