Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: mojo/mojom_bindings_generator.gypi

Issue 1832703002: Mojo: Simplify typemap usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-bindings-variant-import
Patch Set: add missing mash dependency Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/mojo_public.gyp ('k') | mojo/mojom_bindings_generator_explicit.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/mojom_bindings_generator.gypi
diff --git a/mojo/mojom_bindings_generator.gypi b/mojo/mojom_bindings_generator.gypi
index bcf98b229e94cf9eebca7df57e63d3ad8ec32a58..a10c2e47620610cd70789b6fa7186f3fcd90d2d1 100644
--- a/mojo/mojom_bindings_generator.gypi
+++ b/mojo/mojom_bindings_generator.gypi
@@ -8,24 +8,18 @@
],
'variables': {
'variables': {
- 'mojom_typemap_dependencies%': [],
- 'mojom_typemaps%': [],
'mojom_variant%': 'none',
'for_blink%': 'false',
},
- 'mojom_typemap_dependencies%': ['<@(mojom_typemap_dependencies)'],
- 'mojom_typemaps%': ['<@(mojom_typemaps)'],
'mojom_variant%': '<(mojom_variant)',
+ 'mojom_typemaps%': [],
'for_blink%': '<(for_blink)',
'mojom_base_output_dir':
'<!(python <(DEPTH)/build/inverse_depth.py <(DEPTH))',
'mojom_generated_outputs': [
'<!@(python <(DEPTH)/mojo/public/tools/bindings/mojom_list_outputs.py --basedir <(mojom_base_output_dir) --variant <(mojom_variant) <@(_sources))',
],
- 'mojom_generator_typemap_args': [
- '<!@(python <(DEPTH)/mojo/public/tools/bindings/mojom_get_generator_typemap_args.py <@(mojom_typemaps))',
- ],
- 'mojom_extra_generator_args%': [],
+ 'generated_typemap_file': '<(SHARED_INTERMEDIATE_DIR)/<(mojom_base_output_dir)/<(_target_name)_type_mappings',
'conditions': [
['mojom_variant=="none"', {
'mojom_output_languages%': 'c++,javascript,java',
@@ -62,7 +56,23 @@
],
'inputs': [ '<@(_sources)' ],
'outputs': [ '<(stamp_filename)' ],
- }
+ },
+ {
+ 'variables': {
+ 'output': '<(generated_typemap_file)',
+ },
+ 'action_name': '<(_target_name)_type_mappings',
+ 'action': [
+ 'python', '<(DEPTH)/mojo/public/tools/bindings/generate_type_mappings.py',
+ '--output',
+ '<(output)',
+ '<!@(python <(DEPTH)/mojo/public/tools/bindings/format_typemap_generator_args.py <@(mojom_typemaps))',
+ ],
+ 'inputs':[
+ '<(DEPTH)/mojo/public/tools/bindings/generate_type_mappings.py',
+ ],
+ 'outputs': [ '<(output)' ],
+ },
],
'rules': [
{
@@ -78,8 +88,8 @@
},
'inputs': [
'<@(mojom_bindings_generator_sources)',
- '<@(mojom_typemaps)',
'<(stamp_filename)',
+ '<(generated_typemap_file)',
'<(SHARED_INTERMEDIATE_DIR)/mojo/public/tools/bindings/cpp_templates.zip',
'<(SHARED_INTERMEDIATE_DIR)/mojo/public/tools/bindings/java_templates.zip',
'<(SHARED_INTERMEDIATE_DIR)/mojo/public/tools/bindings/js_templates.zip',
@@ -110,8 +120,8 @@
'--java_output_directory=<(java_out_dir)',
'--variant', '<(mojom_variant)',
'-g', '<(mojom_output_languages)',
- '<@(mojom_generator_typemap_args)',
- '<@(mojom_extra_generator_args)',
+ '--typemap',
+ '<(generated_typemap_file)',
'<@(mojom_generator_wtf_arg)',
'--bytecode_path',
'<(SHARED_INTERMEDIATE_DIR)/mojo/public/tools/bindings',
@@ -124,11 +134,9 @@
'<(DEPTH)/base/base.gyp:base',
'<(DEPTH)/mojo/mojo_public.gyp:mojo_interface_bindings_generation',
'<(DEPTH)/mojo/public/tools/bindings/bindings.gyp:precompile_mojom_bindings_generator_templates',
- '<@(mojom_typemap_dependencies)',
'<@(wtf_dependencies)',
],
'export_dependent_settings': [
- '<@(mojom_typemap_dependencies)',
'<@(wtf_dependencies)',
],
'include_dirs': [
« no previous file with comments | « mojo/mojo_public.gyp ('k') | mojo/mojom_bindings_generator_explicit.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698