Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 18326007: Revert "Debug: support breakpoints set in the middle of statement" (Closed)

Created:
7 years, 5 months ago by Peter.Rybin
Modified:
7 years, 5 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Revert "Debug: support breakpoints set in the middle of statement" Rollback per ARM build failure: http://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20builder/builds/7143 Committed: http://code.google.com/p/v8/source/detail?r=15418

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -138 lines) Patch
M src/debug.h View 4 chunks +3 lines, -14 lines 0 comments Download
M src/debug.cc View 6 chunks +9 lines, -37 lines 0 comments Download
M src/debug-debugger.js View 11 chunks +13 lines, -32 lines 0 comments Download
M src/runtime.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime.cc View 3 chunks +6 lines, -29 lines 0 comments Download
M test/cctest/test-debug.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/debug-breakpoints.js View 3 chunks +3 lines, -22 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Peter.Rybin
TBR=yangguo@chromium.org
7 years, 5 months ago (2013-07-01 13:04:37 UTC) #1
Peter.Rybin
Committed patchset #1 manually as r15418.
7 years, 5 months ago (2013-07-01 13:05:30 UTC) #2
Yang
7 years, 5 months ago (2013-07-01 13:05:31 UTC) #3
Message was sent while issue was closed.
On 2013/07/01 13:04:37, peter.rybin wrote:
> mailto:TBR=yangguo@chromium.org

lgtm

Powered by Google App Engine
This is Rietveld 408576698