Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1832413002: DevTools: Address empty query parameters being displayed fugly. (Closed)

Created:
4 years, 8 months ago by Jonathan Garbee
Modified:
4 years, 7 months ago
Reviewers:
paulirish, caseq
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Address empty query parameters being displayed fugly. BUG=598150 Committed: https://crrev.com/14d5974a300bf83db67442db00ab61b08851a81a Cr-Commit-Position: refs/heads/master@{#393393}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Move empty display into view layer. #

Total comments: 2

Patch Set 3 : Address feedback on code style and string injection #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js View 1 2 2 chunks +14 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/requestHeadersView.css View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
Jonathan Garbee
PTAL. Related bug has screenshot in comment #3 of the output.
4 years, 8 months ago (2016-03-28 17:37:05 UTC) #2
caseq
https://codereview.chromium.org/1832413002/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js File third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js (right): https://codereview.chromium.org/1832413002/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js#newcode864 third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js:864: return {name: "(empty)", value: "(empty)"}; I'd rather say we ...
4 years, 8 months ago (2016-04-06 18:36:43 UTC) #3
paulirish
+1 to that. Let's add the (empty) string inside the refreshHeaderParams templating
4 years, 8 months ago (2016-04-08 01:04:38 UTC) #4
Jonathan Garbee
On 2016/04/08 at 01:04:38, paulirish wrote: > +1 to that. Let's add the (empty) string ...
4 years, 8 months ago (2016-04-08 16:41:44 UTC) #5
caseq
https://codereview.chromium.org/1832413002/diff/20001/third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js File third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js (right): https://codereview.chromium.org/1832413002/diff/20001/third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js#newcode173 third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js:173: div.classList.add('empty-value'); "double quotes" please. https://codereview.chromium.org/1832413002/diff/20001/third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js#newcode282 third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js:282: paramNameValue.appendChild(this._formatParameter("(empty)", "empty-request-header", this._decodeRequestParameters)); ...
4 years, 8 months ago (2016-04-11 13:43:18 UTC) #6
Jonathan Garbee
On 2016/04/11 at 13:43:18, caseq wrote: > https://codereview.chromium.org/1832413002/diff/20001/third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js > File third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js (right): > > https://codereview.chromium.org/1832413002/diff/20001/third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js#newcode173 ...
4 years, 7 months ago (2016-05-12 19:52:20 UTC) #7
caseq
lgtm
4 years, 7 months ago (2016-05-12 22:05:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832413002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832413002/40001
4 years, 7 months ago (2016-05-12 22:05:38 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-12 23:23:57 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 23:25:38 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/14d5974a300bf83db67442db00ab61b08851a81a
Cr-Commit-Position: refs/heads/master@{#393393}

Powered by Google App Engine
This is Rietveld 408576698