Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js

Issue 1832413002: DevTools: Address empty query parameters being displayed fugly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback on code style and string injection Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/requestHeadersView.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js b/third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js
index 7891d10530ada86b81b71d423ae0ec69e3a998c4..467952e3ac27a2e14fdbc3397dbdd02eb0850518 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js
@@ -123,6 +123,8 @@ WebInspector.RequestHeadersView.prototype = {
}
}
var div = createElementWithClass("div", className);
+ if (value === "")
+ div.classList.add("empty-value");
if (errorDecoding)
div.createChild("span", "error-message").textContent = WebInspector.UIString("(unable to decode value)");
else
@@ -225,14 +227,18 @@ WebInspector.RequestHeadersView.prototype = {
for (var i = 0; i < params.length; ++i) {
var paramNameValue = createDocumentFragment();
- var name = this._formatParameter(params[i].name + ":", "header-name", this._decodeRequestParameters);
- var value = this._formatParameter(params[i].value, "header-value source-code", this._decodeRequestParameters);
- paramNameValue.appendChild(name);
- paramNameValue.appendChild(value);
-
- var parmTreeElement = new TreeElement(paramNameValue);
- parmTreeElement.selectable = false;
- paramsTreeElement.appendChild(parmTreeElement);
+ if (params[i].name !== "") {
+ var name = this._formatParameter(params[i].name + ":", "header-name", this._decodeRequestParameters);
+ var value = this._formatParameter(params[i].value, "header-value source-code", this._decodeRequestParameters);
+ paramNameValue.appendChild(name);
+ paramNameValue.appendChild(value);
+ } else {
+ paramNameValue.appendChild(this._formatParameter(WebInspector.UIString("(empty)"), "empty-request-header", this._decodeRequestParameters));
+ }
+
+ var paramTreeElement = new TreeElement(paramNameValue);
+ paramTreeElement.selectable = false;
+ paramsTreeElement.appendChild(paramTreeElement);
}
},
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/requestHeadersView.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698