Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1832333003: (1) Finish font subresource loading of SVG synchronously in SVGImage::dataChanged()

Created:
4 years, 8 months ago by hiroshige
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews, krit, kouhei+svg_chromium.org, fs, f(malita), blink-reviews, gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@SVG_new2_0
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

(1) Finish font subresource loading of SVG synchronously in SVGImage::dataChanged() BUG=

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Renbase. #

Patch Set 4 : Rebase. #

Patch Set 5 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/svg/as-image/data-font-in-css-crash.html View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/as-image/data-font-in-css-crash-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/as-image/data-font-in-css-invalid-data-url-crash.html View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/as-image/data-font-in-css-invalid-data-url-crash-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/as-image/data-font-in-css-invalid-font-crash.html View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/as-image/data-font-in-css-invalid-font-crash-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/as-image/resources/data-font-in-css.svg View 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/as-image/resources/data-font-in-css-invalid-data-url.svg View 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/as-image/resources/data-font-in-css-invalid-font.svg View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1833303002 Patch 380001

Messages

Total messages: 18 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832333003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832333003/20001
4 years, 8 months ago (2016-03-28 22:03:16 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/136610)
4 years, 8 months ago (2016-03-28 22:51:00 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832333003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832333003/40001
4 years, 8 months ago (2016-03-29 03:33:34 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oilpan_rel/builds/22545)
4 years, 8 months ago (2016-03-29 04:39:09 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832333003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832333003/60001
4 years, 8 months ago (2016-03-29 17:39:18 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oilpan_rel/builds/22821)
4 years, 8 months ago (2016-03-29 18:47:38 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832333003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832333003/100001
4 years, 8 months ago (2016-04-04 02:26:07 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 03:37:48 UTC) #18 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698