Localized Chromoting Host on Windows.

Localized Chromoting Host on Windows.

This CL introduces remoting/tools/localize.py script. The script is based on Jinja2 templating language. It is used to generate localizable resources (string table, dialogs, message table and version information) from a common template. The translated strings are taken from json files (used by the webapp as well), which, in turn, are generated from remoting_strings.grd.

Collateral changes:
  - Branding of Window resources has been moved to remoting_strings.grd. .ver files are not used anymore.
  - Updated verify_resources.py so that it could recognize strings used by Jinja2 templates.
  - Fixed the dialog layouts for RTL languages.

TBR=cpu@chromium.org
BUG=155204
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210591

[alexeypa (please no reviews), 2013-07-03 17:33:04]

PTAL

[alexeypa (please no reviews), 2013-07-08 17:09:15]

Just a friendly post 4th of July ping. :-)

[garykac, 2013-07-09 00:34:12]

https://codereview.chromium.org/18323017/diff/1/remoting/host/win/core_resour...
File remoting/host/win/core_resource.h (right):

https://codereview.chromium.org/18323017/diff/1/remoting/host/win/core_resour...
remoting/host/win/core_resource.h:11: //      |IDS_CONTROLLER| and
|IDD_VERIFY_CONFIG_DIALOG| are hardcoded in
IDS_CONTROLLER_NAME

https://codereview.chromium.org/18323017/diff/1/remoting/remoting.gyp
File remoting/remoting.gyp (right):

https://codereview.chromium.org/18323017/diff/1/remoting/remoting.gyp#newcode771
remoting/remoting.gyp:771: 'BINARY=4',
These values can't be made into strings?

BINARY=HOST_PLUGIN would be much nicer that BINARY=4

https://codereview.chromium.org/18323017/diff/1/remoting/tools/localize.py
File remoting/tools/localize.py (right):

https://codereview.chromium.org/18323017/diff/1/remoting/tools/localize.py#ne...
remoting/tools/localize.py:64: 'ar' : [ '0401', '04e8', 'LANG_ARABIC',
'SUBLANG_DEFAULT' ],
Is there an order to this list?  I expected it to be alphabetized (except for
the few special cases).

https://codereview.chromium.org/18323017/diff/1/remoting/tools/verify_resourc...
File remoting/tools/verify_resources.py (right):

https://codereview.chromium.org/18323017/diff/1/remoting/tools/verify_resourc...
remoting/tools/verify_resources.py:75: elif file_type == 'template':
Would '.jinja' or '.jinja_template' be a better extension than '.template'?

[alexeypa (please no reviews), 2013-07-09 01:05:23]

https://codereview.chromium.org/18323017/diff/1/remoting/host/win/core_resour...
File remoting/host/win/core_resource.h (right):

https://codereview.chromium.org/18323017/diff/1/remoting/host/win/core_resour...
remoting/host/win/core_resource.h:11: //      |IDS_CONTROLLER| and
|IDD_VERIFY_CONFIG_DIALOG| are hardcoded in
On 2013/07/09 00:34:12, garykac wrote:
> IDS_CONTROLLER_NAME

Done.

https://codereview.chromium.org/18323017/diff/1/remoting/remoting.gyp
File remoting/remoting.gyp (right):

https://codereview.chromium.org/18323017/diff/1/remoting/remoting.gyp#newcode771
remoting/remoting.gyp:771: 'BINARY=4',
On 2013/07/09 00:34:12, garykac wrote:
> These values can't be made into strings?
> 
> BINARY=HOST_PLUGIN would be much nicer that BINARY=4

Done.

https://codereview.chromium.org/18323017/diff/1/remoting/tools/localize.py
File remoting/tools/localize.py (right):

https://codereview.chromium.org/18323017/diff/1/remoting/tools/localize.py#ne...
remoting/tools/localize.py:64: 'ar' : [ '0401', '04e8', 'LANG_ARABIC',
'SUBLANG_DEFAULT' ],
On 2013/07/09 00:34:12, garykac wrote:
> Is there an order to this list?  I expected it to be alphabetized (except for
> the few special cases).

Done.

https://codereview.chromium.org/18323017/diff/1/remoting/tools/verify_resourc...
File remoting/tools/verify_resources.py (right):

https://codereview.chromium.org/18323017/diff/1/remoting/tools/verify_resourc...
remoting/tools/verify_resources.py:75: elif file_type == 'template':
On 2013/07/09 00:34:12, garykac wrote:
> Would '.jinja' or '.jinja_template' be a better extension than '.template'?

Done.

[alexeypa (please no reviews), 2013-07-09 01:19:54]

Adding cpu@ because of this:

** Presubmit Messages **
Missing LGTM from OWNERS of directories added to DEPS:
    '+third_party/jinja2',

Though third_party/OWNERS says that LGTM is only required when adding a new
library to third_party, not when a new reference is added to DEPS.

[garykac, 2013-07-09 01:30:08]

lgtm

[cpu_(ooo_6.6-7.5), 2013-07-09 02:34:15]

yeah, just TBR me.

[commit-bot: I haz the power, 2013-07-09 15:38:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/18323017/24001

[commit-bot: I haz the power, 2013-07-09 17:27:35]

Change committed as 210591

[Nico, 2017-09-02 23:13:36]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-09-02 23:13:37]

https://codereview.chromium.org/18323017/diff/24001/remoting/host/remoting_ho...
File remoting/host/remoting_host_messages.mc (left):

https://codereview.chromium.org/18323017/diff/24001/remoting/host/remoting_ho...
remoting/host/remoting_host_messages.mc:7: 
Why did we localize the .mc file? This is only used for log output, which is for
devs / sysadmins mostly, right? We don't localize our other .mc files. Would
anyone have a problem with me undoing this change? (Or maybe changing the .jinja
template so that it only passes through english?)

[Jamie, 2017-09-05 21:03:25]

On 2017/09/02 23:13:37, Nico wrote:
>
https://codereview.chromium.org/18323017/diff/24001/remoting/host/remoting_ho...
> File remoting/host/remoting_host_messages.mc (left):
> 
>
https://codereview.chromium.org/18323017/diff/24001/remoting/host/remoting_ho...
> remoting/host/remoting_host_messages.mc:7: 
> Why did we localize the .mc file? This is only used for log output, which is
for
> devs / sysadmins mostly, right? We don't localize our other .mc files. Would
> anyone have a problem with me undoing this change? (Or maybe changing the
.jinja
> template so that it only passes through english?)

I don't remember us ever discussing it; I suspect Alex just did it automatically
as it contains English strings. I think unlocalizing this file is fine, but
please don't undo this entire change--I'm sure that wasn't what you were
suggesting :)

[Nico, 2017-09-05 21:07:36]

On Tue, Sep 5, 2017 at 5:03 PM, <jamiewalch@chromium.org> wrote:

> On 2017/09/02 23:13:37, Nico wrote:
> >
> https://codereview.chromium.org/18323017/diff/24001/
> remoting/host/remoting_host_messages.mc
> > File remoting/host/remoting_host_messages.mc (left):
> >
> >
> https://codereview.chromium.org/18323017/diff/24001/
> remoting/host/remoting_host_messages.mc#oldcode7
> > remoting/host/remoting_host_messages.mc:7:
> > Why did we localize the .mc file? This is only used for log output,
> which is
> for
> > devs / sysadmins mostly, right? We don't localize our other .mc files.
> Would
> > anyone have a problem with me undoing this change? (Or maybe changing the
> .jinja
> > template so that it only passes through english?)
>
> I don't remember us ever discussing it; I suspect Alex just did it
> automatically
> as it contains English strings. I think unlocalizing this file is fine, but
> please don't undo this entire change--I'm sure that wasn't what you were
> suggesting :)
>

Here's what I had in mind:
https://chromium-review.googlesource.com/c/chromium/src/+/649886

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.