src/core/SkCanvas.cpp - Issue 1832223002: switch xfermodes over to sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkCanvas.cpp

Issue 1832223002: switch xfermodes over to sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkCanvas.cpp

diff --git a/src/core/SkCanvas.cpp b/src/core/SkCanvas.cpp

index 258343a92f6644909b65cb605fb7a13a6f0673e8..f1777441d65b305a11dd442ab4ef35834b991a89 100644

--- a/src/core/SkCanvas.cpp

+++ b/src/core/SkCanvas.cpp

@@ -481,7 +481,7 @@ public:

SkPaint tmp;

tmp.setImageFilter(fPaint->getImageFilter());

- tmp.setXfermode(fPaint->getXfermode());

+ tmp.setXfermode(sk_ref_sp(fPaint->getXfermode()));

SkRect storage;

if (rawBounds) {

// Make rawBounds include all paint outsets except for those due to image filters.