src/core/SkBitmapProcShader.cpp - Issue 1832223002: switch xfermodes over to sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkBitmapProcShader.cpp

Issue 1832223002: switch xfermodes over to sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkBitmapProcShader.cpp

diff --git a/src/core/SkBitmapProcShader.cpp b/src/core/SkBitmapProcShader.cpp

index 0a3c0eaeb7f0da2eb44f336077fc2de70bd3b895..14114c08937bed7697a6ebf15f9fb23acbee0ff6 100644

--- a/src/core/SkBitmapProcShader.cpp

+++ b/src/core/SkBitmapProcShader.cpp

@@ -132,7 +132,7 @@ public:

// To implement the old shadeSpan entry-point, we need to efficiently convert our native

// floats into SkPMColor. The SkXfermode::D32Procs do exactly that.

- sk_sp<SkXfermode> xfer(SkXfermode::Create(SkXfermode::kSrc_Mode));

+ sk_sp<SkXfermode> xfer(SkXfermode::Make(SkXfermode::kSrc_Mode));

fXferProc = SkXfermode::GetD32Proc(xfer.get(), 0);

}