Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1832143003: Mojom frontend: Don't stop after processing the first method. (Closed)

Created:
4 years, 9 months ago by rudominer
Modified:
4 years, 9 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mojom frontend: Don't stop after processing the first method. This patch fixes a bug introduced in https://codereview.chromium.org/1833593002 but never deployed. This was a logic error that caused us to quit after processing the packing data for the first method in in an interface. In this patch we fix the bug, add a test for it, and also update the sha1 so that we are actually deploying the fix. The changes to the .mojom.dart files must be from some earlier change that was never deployed. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/d100172713b0b1fd26dddab3474bb83bbb15a8db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -22 lines) Patch
M mojo/dart/packages/_mojo_for_test_only/lib/dart_to_cpp/dart_to_cpp.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/imported/sample_import.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/imported/sample_import2.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/math/math_calculator.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/examples/echo.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/rect.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/serialization_test_structs.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_enums.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_structs.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_unions.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/validation_test_interfaces.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/versioning/versioning_test_client.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/regression_tests/regression_tests.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_factory.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_service.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/gfx/composition/compositor.mojom.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/ui/view_manager.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom_tool/bin/linux64/mojom.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom_tool/bin/mac64/mojom.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M mojom/mojom_parser/mojom/computed_data.go View 1 chunk +6 lines, -2 lines 0 comments Download
M mojom/mojom_parser/serialization/serialization_test.go View 1 chunk +132 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
rudominer
Hi Vardhan, ptal.
4 years, 9 months ago (2016-03-26 00:50:33 UTC) #4
vardhan
lgtm
4 years, 9 months ago (2016-03-26 00:52:22 UTC) #5
rudominer
4 years, 9 months ago (2016-03-26 00:57:14 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
d100172713b0b1fd26dddab3474bb83bbb15a8db (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698