mus: Remove unnecessary const from property TypeConverter templates

mus: Remove unnecessary const from property TypeConverter templates

This allows them to be used with the idiomatic mojo::ConvertTo<Foo>() template.

(In particular, ConvertTo<Foo>(my_vector) matches my_vector to "const U&" to
determine which TypeConverter to call. If my_vector is either a "std::vector"
or a "const std::vector" it ends up looking for TypeConverter<Foo, std::vector>.
Since the second TypeConverter template parameter isn't const, the compiler
can't find our existing TypeConverter<Foo, const std::vector> functions. These
functions don't need their template parameter to be const std::vector, as they
use "const std::vector&" for their inputs regardless.)

BUG=none
TEST=compiles

Committed: https://crrev.com/da88c32858fdbc6040b07d51019d9f564e37416e
Cr-Commit-Position: refs/heads/master@{#383366}

[James Cook, 2016-03-25 18:14:25]

jamescook@chromium.org changed reviewers:
+ rockot@chromium.org

[James Cook, 2016-03-25 18:14:26]

Ken, please take a look.

Can you also make sure my CL description is correct?

[James Cook, 2016-03-25 18:14:31]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-25 18:14:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1832133002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1832133002/1

[commit-bot: I haz the power, 2016-03-25 18:18:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-25 18:18:02]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ken Rockot(use gerrit already), 2016-03-25 19:24:09]

woot, lgtm % rebase

[James Cook, 2016-03-25 20:27:44]

Ken, can you take another look? I missed a couple files the first time.

[Ken Rockot(use gerrit already), 2016-03-25 20:30:11]

still lgtm

[James Cook, 2016-03-25 20:32:25]

jamescook@chromium.org changed reviewers:
+ sky@chromium.org

[James Cook, 2016-03-25 20:32:25]

Scott, can I get OWNERS?

[sky, 2016-03-25 20:39:34]

LGTM

[James Cook, 2016-03-25 20:45:11]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-03-25 20:45:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1832133002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1832133002/40001

[commit-bot: I haz the power, 2016-03-25 21:29:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-25 21:30:08]

Description was changed from

==========
mus: Remove unnecessary const from property TypeConverter templates

This allows them to be used with the idiomatic mojo::ConvertTo<Foo>() template.

(In particular, ConvertTo<Foo>(my_vector) matches my_vector to "const U&" to
determine which TypeConverter to call. If my_vector is either a "std::vector"
or a "const std::vector" it ends up looking for TypeConverter<Foo, std::vector>.
Since the second TypeConverter template parameter isn't const, the compiler
can't find our existing TypeConverter<Foo, const std::vector> functions. These
functions don't need their template parameter to be const std::vector, as they
use "const std::vector&" for their inputs regardless.)

BUG=none
TEST=compiles
==========

to

==========
mus: Remove unnecessary const from property TypeConverter templates

This allows them to be used with the idiomatic mojo::ConvertTo<Foo>() template.

(In particular, ConvertTo<Foo>(my_vector) matches my_vector to "const U&" to
determine which TypeConverter to call. If my_vector is either a "std::vector"
or a "const std::vector" it ends up looking for TypeConverter<Foo, std::vector>.
Since the second TypeConverter template parameter isn't const, the compiler
can't find our existing TypeConverter<Foo, const std::vector> functions. These
functions don't need their template parameter to be const std::vector, as they
use "const std::vector&" for their inputs regardless.)

BUG=none
TEST=compiles

Committed: https://crrev.com/da88c32858fdbc6040b07d51019d9f564e37416e
Cr-Commit-Position: refs/heads/master@{#383366}
==========

[commit-bot: I haz the power, 2016-03-25 21:30:09]

Patchset 3 (id:??) landed as
https://crrev.com/da88c32858fdbc6040b07d51019d9f564e37416e
Cr-Commit-Position: refs/heads/master@{#383366}