Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Unified Diff: components/mus/public/cpp/tests/property_type_converters_unittest.cc

Issue 1832133002: mus: Remove unnecessary const from property TypeConverter templates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: format Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/mus/public/cpp/tests/property_type_converters_unittest.cc
diff --git a/components/mus/public/cpp/tests/property_type_converters_unittest.cc b/components/mus/public/cpp/tests/property_type_converters_unittest.cc
index 7726172657a112efc0b215959c78adb057de3177..f1a4b896c5bc35449e7977fabe74f8090d0a4c9f 100644
--- a/components/mus/public/cpp/tests/property_type_converters_unittest.cc
+++ b/components/mus/public/cpp/tests/property_type_converters_unittest.cc
@@ -31,7 +31,7 @@ SkBitmap MakeBitmap() {
TEST(PropertyTypeConvertersTest, SkBitmapSerialize) {
SkBitmap bitmap = MakeBitmap();
std::vector<uint8_t> bytes =
- TypeConverter<const std::vector<uint8_t>, SkBitmap>::Convert(bitmap);
+ TypeConverter<std::vector<uint8_t>, SkBitmap>::Convert(bitmap);
// Size should be 4 bytes of header plus size of RGBA pixels.
ASSERT_EQ(4 + bitmap.getSize(), bytes.size());
@@ -51,7 +51,7 @@ TEST(PropertyTypeConvertersTest, SkBitmapDeserialize) {
// Make a 1x2 pixel bitmap.
std::vector<uint8_t> bytes = {0, 1, 0, 2, 11, 22, 33, 44, 55, 66, 77, 88};
SkBitmap bitmap =
- TypeConverter<SkBitmap, const std::vector<uint8_t>>::Convert(bytes);
+ TypeConverter<SkBitmap, std::vector<uint8_t>>::Convert(bytes);
EXPECT_EQ(1, bitmap.width());
EXPECT_EQ(2, bitmap.height());
// The image pixels match the vector bytes.
@@ -63,9 +63,9 @@ TEST(PropertyTypeConvertersTest, SkBitmapDeserialize) {
TEST(PropertyTypeConvertersTest, SkBitmapRoundTrip) {
SkBitmap bitmap1 = MakeBitmap();
std::vector<uint8_t> bytes =
- TypeConverter<const std::vector<uint8_t>, SkBitmap>::Convert(bitmap1);
+ TypeConverter<std::vector<uint8_t>, SkBitmap>::Convert(bitmap1);
SkBitmap bitmap2 =
- TypeConverter<SkBitmap, const std::vector<uint8_t>>::Convert(bytes);
+ TypeConverter<SkBitmap, std::vector<uint8_t>>::Convert(bytes);
EXPECT_TRUE(gfx::BitmapsAreEqual(bitmap1, bitmap2));
}
@@ -73,7 +73,7 @@ TEST(PropertyTypeConvertersTest, SkBitmapRoundTrip) {
TEST(PropertyTypeConvertersTest, SkBitmapSerializeEmpty) {
SkBitmap bitmap;
std::vector<uint8_t> bytes =
- TypeConverter<const std::vector<uint8_t>, SkBitmap>::Convert(bitmap);
+ TypeConverter<std::vector<uint8_t>, SkBitmap>::Convert(bitmap);
EXPECT_TRUE(bytes.empty());
}
@@ -81,7 +81,7 @@ TEST(PropertyTypeConvertersTest, SkBitmapSerializeEmpty) {
TEST(PropertyTypeConvertersTest, SkBitmapDeserializeEmpty) {
std::vector<uint8_t> bytes;
SkBitmap bitmap =
- TypeConverter<SkBitmap, const std::vector<uint8_t>>::Convert(bytes);
+ TypeConverter<SkBitmap, std::vector<uint8_t>>::Convert(bytes);
EXPECT_TRUE(bitmap.isNull());
}

Powered by Google App Engine
This is Rietveld 408576698