customtabs: Don't always record non-matching fragments are prediction failures.

customtabs: Don't always record non-matching fragments are prediction failures.

When fragments are set to be ignored for URL matching for a given
session, update the statistics (and the throttling) the same way.

BUG=597947
Committed: https://crrev.com/12f9b4ab77e708a5d8ad3a69161cab30cd484902
Cr-Commit-Position: refs/heads/master@{#383710}

[Benoit L, 2016-03-25 14:04:29]

lizeb@chromium.org changed reviewers:
+ pasko@chromium.org, yusufo@chromium.org

[pasko, 2016-03-25 15:12:07]

lgtm

https://codereview.chromium.org/1832063002/diff/10001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java
(right):

https://codereview.chromium.org/1832063002/diff/10001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java:200:
boolean urlsMatch = TextUtils.equals(predictedUrl, url)
instead of a multiline condition I would prefer something like:

if (TextUtils.equals(predictedUrl, url)) return GOOD_PREDICTION;

if (params.mIgnoreFragments &&
UrlUtilities.urlsMatchIgnoringFragments(predictedUrl, url))
    return GOOD_PREDICTION;

return BAD_PREDICTION;

// I checked it fits 100 chars width

Up to you.

Nit.

[Benoit L, 2016-03-29 09:26:10]

The CQ bit was checked by lizeb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 09:26:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1832063002/10001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1832063002/10001

[commit-bot: I haz the power, 2016-03-29 09:36:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 09:36:45]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[Benoit L, 2016-03-29 12:04:44]

The CQ bit was checked by lizeb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 12:04:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1832063002/30001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1832063002/30001

[commit-bot: I haz the power, 2016-03-29 12:46:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 12:46:41]

Dry run: This issue passed the CQ dry run.

[Benoit L, 2016-03-29 13:15:06]

The CQ bit was checked by lizeb@chromium.org

[Benoit L, 2016-03-29 13:15:07]

The patchset sent to the CQ was uploaded after l-g-t-m from pasko@chromium.org
Link to the patchset: https://codereview.chromium.org/1832063002/#ps30001
(title: ".")

[commit-bot: I haz the power, 2016-03-29 13:15:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1832063002/30001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1832063002/30001

[commit-bot: I haz the power, 2016-03-29 13:20:49]

Committed patchset #3 (id:30001)

[commit-bot: I haz the power, 2016-03-29 13:22:07]

Description was changed from

==========
customtabs: Don't always record non-matching fragments are prediction failures.

When fragments are set to be ignored for URL matching for a given
session, update the statistics (and the throttling) the same way.

BUG=597947
==========

to

==========
customtabs: Don't always record non-matching fragments are prediction failures.

When fragments are set to be ignored for URL matching for a given
session, update the statistics (and the throttling) the same way.

BUG=597947

Committed: https://crrev.com/12f9b4ab77e708a5d8ad3a69161cab30cd484902
Cr-Commit-Position: refs/heads/master@{#383710}
==========

[commit-bot: I haz the power, 2016-03-29 13:22:08]

Patchset 3 (id:??) landed as
https://crrev.com/12f9b4ab77e708a5d8ad3a69161cab30cd484902
Cr-Commit-Position: refs/heads/master@{#383710}