Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1650)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/ClientManagerTest.java

Issue 1832063002: customtabs: Don't always record non-matching fragments are prediction failures. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/ClientManagerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/ClientManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/ClientManagerTest.java
index b28cfaeaf613ff81512958315c2035a245bdc21a..d9920a837c92ced1cdbe31b95b4ad416fc28a890 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/ClientManagerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/ClientManagerTest.java
@@ -11,6 +11,9 @@ import android.support.customtabs.ICustomTabsCallback;
import android.test.InstrumentationTestCase;
import android.test.suitebuilder.annotation.SmallTest;
+import org.chromium.base.library_loader.LibraryLoader;
+import org.chromium.base.library_loader.LibraryProcessType;
+
/** Tests for ClientManager. */
public class ClientManagerTest extends InstrumentationTestCase {
private static final String URL = "https://www.android.com";
@@ -23,6 +26,9 @@ public class ClientManagerTest extends InstrumentationTestCase {
protected void setUp() throws Exception {
super.setUp();
Context context = getInstrumentation().getTargetContext().getApplicationContext();
+ // UrlUtilities used in ClientManager#getPredictionOutcome() needs the native library.
+ LibraryLoader.get(LibraryProcessType.PROCESS_BROWSER).ensureInitialized(context);
+ RequestThrottler.purgeAllEntriesForTesting(context);
mClientManager = new ClientManager(context);
}
@@ -81,4 +87,39 @@ public class ClientManagerTest extends InstrumentationTestCase {
mClientManager.newSession(callback, mUid, null);
assertEquals(ClientManager.SESSION_WARMUP, mClientManager.getWarmupState(session));
}
+
+ @SmallTest
+ public void testPredictionOutcomeSuccess() {
+ assertTrue(mClientManager.newSession(mCallback, mUid, null));
+ assertTrue(mClientManager.updateStatsAndReturnWhetherAllowed(mSession, mUid, URL));
+ assertEquals(
+ ClientManager.GOOD_PREDICTION, mClientManager.getPredictionOutcome(mSession, URL));
+ }
+
+ @SmallTest
+ public void testPredictionOutcomeNoPrediction() {
+ assertTrue(mClientManager.newSession(mCallback, mUid, null));
+ mClientManager.recordUidHasCalledWarmup(mUid);
+ assertEquals(
+ ClientManager.NO_PREDICTION, mClientManager.getPredictionOutcome(mSession, URL));
+ }
+
+ @SmallTest
+ public void testPredictionOutcomeBadPrediction() {
+ assertTrue(mClientManager.newSession(mCallback, mUid, null));
+ assertTrue(mClientManager.updateStatsAndReturnWhetherAllowed(mSession, mUid, URL));
+ assertEquals(
+ ClientManager.BAD_PREDICTION,
+ mClientManager.getPredictionOutcome(mSession, URL + "#fragment"));
+ }
+
+ @SmallTest
+ public void testPredictionOutcomeIgnoreFragment() {
+ assertTrue(mClientManager.newSession(mCallback, mUid, null));
+ assertTrue(mClientManager.updateStatsAndReturnWhetherAllowed(mSession, mUid, URL));
+ mClientManager.setIgnoreFragmentsForSession(mSession, true);
+ assertEquals(
+ ClientManager.GOOD_PREDICTION,
+ mClientManager.getPredictionOutcome(mSession, URL + "#fragment"));
+ }
}
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698