Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1513)

Unified Diff: ui/views/controls/scrollbar/cocoa_scroll_bar.mm

Issue 1831883002: Use sk_sp-based shader creation APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sprinkle in some std::move and some sk_sp in the API Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/scrollbar/cocoa_scroll_bar.mm
diff --git a/ui/views/controls/scrollbar/cocoa_scroll_bar.mm b/ui/views/controls/scrollbar/cocoa_scroll_bar.mm
index 0c11da41a8da34094a3a169e50ef72652b7a5b1f..f11ea1a237d0e9ef9e32d8911abdf6911be15023 100644
--- a/ui/views/controls/scrollbar/cocoa_scroll_bar.mm
+++ b/ui/views/controls/scrollbar/cocoa_scroll_bar.mm
@@ -254,11 +254,10 @@ void CocoaScrollBar::OnPaint(gfx::Canvas* canvas) {
gradient_bounds[0].set(track_rect.x(), track_rect.y());
gradient_bounds[1].set(track_rect.right(), track_rect.y());
}
- skia::RefPtr<SkShader> shader = skia::AdoptRef(SkGradientShader::CreateLinear(
+ SkPaint gradient;
+ gradient.setShader(SkGradientShader::MakeLinear(
gradient_bounds, kScrollerTrackGradientColors, nullptr,
arraysize(kScrollerTrackGradientColors), SkShader::kClamp_TileMode));
- SkPaint gradient;
- gradient.setShader(shader.get());
canvas->DrawRect(track_rect, gradient);
// Draw the inner border: top if horizontal, left if vertical.

Powered by Google App Engine
This is Rietveld 408576698