Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1831843002: Revert of Add bisect config validation. (Closed)

Created:
4 years, 9 months ago by qyearsley
Modified:
4 years, 9 months ago
Reviewers:
RobertoCN, chrisphan
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, prasadv, sullivan
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Add bisect config validation. (patchset #4 id:60001 of https://codereview.chromium.org/1782333002/ ) Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=597655 Original issue's description: > Add bisect config validation. > > BUG=485672 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299450 TBR=chrisphan@chromium.org,robertocn@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=485672 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299470

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -389 lines) Patch
M scripts/slave/recipe_modules/auto_bisect/bisector.py View 4 chunks +4 lines, -17 lines 0 comments Download
D scripts/slave/recipe_modules/auto_bisect/config_validation.py View 1 chunk +0 lines, -110 lines 0 comments Download
D scripts/slave/recipe_modules/auto_bisect/config_validation_test.py View 1 chunk +0 lines, -164 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.py View 3 chunks +2 lines, -7 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/android_arm64_bisector.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/android_bisector.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/basic.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/basic_bisect_script.json View 3 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/delayed_build_test.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/failed_build_test.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/failed_test.json View 1 chunk +1 line, -1 line 0 comments Download
D scripts/slave/recipe_modules/auto_bisect/example.expected/invalid_config.json View 1 chunk +0 lines, -66 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/mac_bisector.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/missing_metric_test.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/reversed_basic.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/windows_bisector.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/windows_x64_bisector.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/bisect_test/example_bisect_results.py View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisect_test/example_bisect_results.expected/aborted_non_telemetry_test.json View 3 chunks +4 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisect_test/example_bisect_results.expected/basic_test.json View 3 chunks +4 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisect_test/example_bisect_results.expected/deps_culprit_test.json View 3 chunks +4 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisect_test/example_bisect_results.expected/failed_direction_test.json View 3 chunks +4 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisect_test/example_bisect_results.expected/failed_test.json View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
qyearsley
Created Revert of Add bisect config validation.
4 years, 9 months ago (2016-03-24 16:42:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831843002/1
4 years, 9 months ago (2016-03-24 16:43:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=299470
4 years, 9 months ago (2016-03-24 16:43:13 UTC) #4
qyearsley
4 years, 9 months ago (2016-03-24 22:44:12 UTC) #5
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1827313002/ by qyearsley@chromium.org.

The reason for reverting is: Reland bisect config validation with bug fix.

Powered by Google App Engine
This is Rietveld 408576698