Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: scripts/slave/recipe_modules/auto_bisect/bisector.py

Issue 1831843002: Revert of Add bisect config validation. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect/config_validation.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/auto_bisect/bisector.py
diff --git a/scripts/slave/recipe_modules/auto_bisect/bisector.py b/scripts/slave/recipe_modules/auto_bisect/bisector.py
index cd5b59b2526d53b6d0d04e95d31e2aa15233e2fc..b2002b08ce0931a0639d6a13743388ed0a833c87 100644
--- a/scripts/slave/recipe_modules/auto_bisect/bisector.py
+++ b/scripts/slave/recipe_modules/auto_bisect/bisector.py
@@ -7,7 +7,6 @@
import time
import urllib
-from . import config_validation
from . import depot_config
from . import revision_state
@@ -76,12 +75,11 @@
"""
super(Bisector, self).__init__()
self._api = api
- self.result_codes = set()
self.ensure_sync_master_branch()
self.bisect_config = bisect_config
self.config_step()
- self._validate_config()
self.revision_class = revision_class
+ self.result_codes = set()
self.last_tested_revision = None
# Test-only properties.
@@ -191,9 +189,8 @@
return significantly_different
def config_step(self):
- """Yields a step that prints the bisect config."""
+ """Yields a simple echo step that outputs the bisect config."""
api = self.api
-
# bisect_config may come as a FrozenDict (which is not serializable).
bisect_config = dict(self.bisect_config)
@@ -204,22 +201,12 @@
for k, v in bisect_config.iteritems():
if isinstance(v, basestring):
bisect_config[k] = fix_windows_backslashes(v)
-
# We sort the keys to prevent problems with orders changing when
# recipe_simulation_test compares against expectation files.
config_string = json.dumps(bisect_config, indent=2, sort_keys=True)
- step = api.m.step('config', [])
+ result = api.m.step('config', [])
config_lines = config_string.splitlines()
- step.presentation.logs['Bisect job configuration'] = config_lines
-
- def _validate_config(self):
- """Raises an error and halts the bisect job if the config is invalid."""
- try:
- config_validation.validate_bisect_config(self.bisect_config)
- except config_validation.ValidationFail as error:
- self.surface_result('BAD_CONFIG')
- self.api.m.halt(error.message)
- raise self.api.m.step.StepFailure(error.message)
+ result.presentation.logs['Bisect job configuration'] = config_lines
@property
def api(self):
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect/config_validation.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698