Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 183183005: Add an accessibility role for the iframe element (re-land). (Closed)

Created:
6 years, 9 months ago by dmazzoni
Modified:
6 years, 8 months ago
Reviewers:
dglazkov, aboxhall
CC:
blink-reviews, jamesr, dglazkov+blink, dmazzoni, aboxhall, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add an accessibility role for the iframe element (re-land). We can add a layout test after adding TestRunner support on the Chromium side, or we could just test it in Chromium. BUG=347464 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168156 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170426

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M Source/core/accessibility/AXNodeObject.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/accessibility/AXObject.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/accessibility/AXRenderObject.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M public/web/WebAXEnums.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
dmazzoni
6 years, 9 months ago (2014-02-27 21:00:57 UTC) #1
dglazkov
lgtm
6 years, 9 months ago (2014-02-27 21:01:49 UTC) #2
aboxhall
lgtm
6 years, 9 months ago (2014-02-27 21:47:37 UTC) #3
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 9 months ago (2014-02-28 18:49:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/183183005/1
6 years, 9 months ago (2014-02-28 18:49:40 UTC) #5
commit-bot: I haz the power
Change committed as 168156
6 years, 9 months ago (2014-02-28 19:17:57 UTC) #6
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 8 months ago (2014-03-31 05:52:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/183183005/20001
6 years, 8 months ago (2014-03-31 05:52:14 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 07:01:59 UTC) #9
Message was sent while issue was closed.
Change committed as 170426

Powered by Google App Engine
This is Rietveld 408576698