Source/core/accessibility/AXRenderObject.cpp - Issue 183183005: Add an accessibility role for the iframe element (re-land).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/accessibility/AXRenderObject.cpp

Issue 183183005: Add an accessibility role for the iframe element (re-land). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/accessibility/AXRenderObject.cpp

diff --git a/Source/core/accessibility/AXRenderObject.cpp b/Source/core/accessibility/AXRenderObject.cpp

index a75edbf02cb27d70f5b6d222ca76365f6d4ab889..34021d7cbecbac24630b87ecfcf8495eb4969abc 100644

--- a/Source/core/accessibility/AXRenderObject.cpp

+++ b/Source/core/accessibility/AXRenderObject.cpp

@@ -390,6 +390,9 @@ AccessibilityRole AXRenderObject::determineAccessibilityRole()

if (isHTMLHtmlElement(node))

return IgnoredRole;

+ if (node && node->hasTagName(iframeTag))

+ return IframeRole;

// There should only be one banner/contentInfo per page. If header/footer are being used within an article or section

// then it should not be exposed as whole page's banner/contentInfo

if (node && node->hasTagName(headerTag) && !isDescendantOfElementType(articleTag) && !isDescendantOfElementType(sectionTag))

« no previous file with comments | « Source/core/accessibility/AXObject.h ('k') | Source/web/AssertMatchingEnums.cpp » ('j') | no next file with comments »